Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuildChannel#is_text_based returns true for thread channel #3025

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

m1sk9
Copy link
Contributor

@m1sk9 m1sk9 commented Nov 11, 2024

Make GuildChannel#is_text_based return true for public and private threads.

ref: https://canary.discord.com/channels/381880193251409931/673965002805477386/1305494065613111366 (Serenity Discord)

@github-actions github-actions bot added the model Related to the `model` module. label Nov 11, 2024
@m1sk9 m1sk9 changed the title fix: GuildChannel#is_text_based returns true for thread channel GuildChannel#is_text_based returns true for thread channel Nov 11, 2024
@m1sk9
Copy link
Contributor Author

m1sk9 commented Nov 11, 2024

Forgot cargo fmt. I have made a correction and need CI approval again.

@GnomedDev
Copy link
Member

Can a comment be added to the end of ChannelType along the lines of "Make sure to update GuildChannel::is_text_based" to make sure this stays up to date in future?

@m1sk9
Copy link
Contributor Author

m1sk9 commented Nov 11, 2024

Can a comment be added to the end of ChannelType along the lines of "Make sure to update GuildChannel::is_text_based" to make sure this stays up to date in future?

Added 238c323

@jamesbt365
Copy link
Member

I'm not sure she meant a doc comment, this is something that only really needs to be updated when the developer changes it, it doesn't need to be visible to the user.

@m1sk9
Copy link
Contributor Author

m1sk9 commented Nov 11, 2024

Okay, you're right. Fixed with an abb4d08.

@GnomedDev GnomedDev merged commit e14acaf into serenity-rs:current Nov 11, 2024
22 checks passed
@m1sk9 m1sk9 deleted the fix-is_text_based branch November 12, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants