ELFIO segment memory usage reduction by removing memory duplication #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now if a client requests segment data via get_data(), ELFIO creates a copy of data by reading over data stored in the matching segments. Signed-off-by: Sonal Santan <sonal.santan@amd.com>
…ading. This allows matching of sections to segments and skip loading of segment data if the data is already present in matched sections Signed-off-by: Sonal Santan <sonal.santan@amd.com>
Signed-off-by: Sonal Santan <sonal.santan@amd.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
segment::load_data()if the segment data is already stored in matching sections. This prevents memory duplication which otherwise leads to very large memory usage for ELF with large text/data.segment::get_data()usage, the segment loads the data from the matched sections on demand. Note that users of this API will not see any overall reduction in memory usage. Users are encouraged to get the data directly from sections to avoid data duplication.