Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test session expiry behaviour, use session cookies #4

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Sep 6, 2024

Convert the cookie to a session cookie (rather than fixed expiry). Test the behaviour that cleans up the file uploads when a session becomes inactive.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.51%. Comparing base (92fbc2e) to head (c53f343).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   90.55%   90.51%   -0.05%     
==========================================
  Files           4        4              
  Lines         233      232       -1     
==========================================
- Hits          211      210       -1     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex marked this pull request as ready for review September 6, 2024 13:49
@hillalex hillalex merged commit 971f681 into main Sep 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant