Skip to content

test for path error handling #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TripleDogDare wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test for path error handling #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions serum_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
"encoding/json"
"errors"
"fmt"
"io/fs"
"os"
"testing"

"github.com/serum-errors/go-serum"
Expand Down Expand Up @@ -105,6 +107,44 @@ func TestErrorsIs(t *testing.T) {
t.Fatal("serum-cause wrapping should resolve")
}
})
t.Run("with os.PathError", func(t *testing.T) {
_, fserr := os.Open("non-existing-file")
t.Logf("err: %#v", fserr)
t.Logf("unwrap err: %[1]T %[1]#v", errors.Unwrap(fserr))
t.Logf("err is fs.ErrNotExist: %t", errors.Is(fserr, fs.ErrNotExist))
t.Logf("unwrap err is fs.ErrNotExist: %t", errors.Is(errors.Unwrap(fserr), fs.ErrNotExist))
if fserr == nil {
t.Fatal("error should not be nil")
}
if !errors.Is(fserr, fs.ErrNotExist) {
t.Fatalf("error should be ErrNotExist")
}
t.Run("custom re-wrap", func(t *testing.T) {
pe, ok := fserr.(*fs.PathError)
if !ok {
t.Fatalf("error should be an fs.PathError")
}
t.Logf("inside err: %#v", pe.Err)
err := serum.Error("rewrap", serum.WithCause(pe.Err),
serum.WithMessageTemplate("unable to {{op}} path {{path | q}}"),
serum.WithDetail("op", pe.Op),
serum.WithDetail("path", pe.Path),
)
if !errors.Is(err, fs.ErrNotExist) {
// This doesn't work because we've lost the fs.PathError implementation entirely via Synthesize.
t.Log(fs.ErrNotExist)
t.Fatalf("wrapped error should still be a ErrNotExist; %s", err.Error())
}
})
t.Run("wrap with serum", func(t *testing.T) {
err := serum.Error("rewrap", serum.WithCause(fserr))
if !errors.Is(err, fs.ErrNotExist) {
// This doesn't work because we've lost the fs.PathError implementation entirely via Synthesize.
t.Log(fs.ErrNotExist)
t.Fatalf("wrapped error should still be a ErrNotExist; %s", err.Error())
}
})
})
})
t.Run("non-equivalent serum errors", func(t *testing.T) {
t.Run("with different codes", func(t *testing.T) {
Expand Down