Add components based on ViewComponent #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent - Cleaned up outdated and unnecessary comments in `page_header_component.rb`. - Removed unused descriptive comments in `section_card_component.rb` for clarity. - Simplifies the codebase by eliminating non-informative comments.
- Required `view_component` in `spec_helper.rb` to enable testing for components. - Ensures that ViewComponent-related tests are properly set up.
- Introduced `FullNameService` which constructs a full name from `first_name` and `last_name` inputs. - Added request specs for `ServicesController` to test service endpoints. - Updated dependencies in `gemspec` and `Gemfile.lock`, adding `rspec-rails` for Rails-specific testing functionality.
- Adjusted the require order in `spec_helper.rb` by moving `servactory` to be loaded before `view_component`. - Ensures proper dependency loading and prevents potential errors during tests.
- Rearranged require statements in `spec_helper.rb` to ensure `servactory` is loaded before `view_component`. - Fixes potential loading issues during testing by maintaining dependency order integrity.
- Downgraded `rspec-rails` development dependency from `>= 8.0` to `>= 7.0` in `servactory-web.gemspec`. - Updated `Gemfile.lock` to reflect this change. - Ensures compatibility with older versions of `rspec-rails` while maintaining functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.