Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent String.repeat range error #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b3nThomas
Copy link

@b3nThomas b3nThomas commented Mar 9, 2022

Fixes #25

Small PR to prevent a negative value from being used for borderLength, and in turn, throwing a range error.
This only happens when process.stdout.columns is equal to 0, for example, when running inside Docker without an interactive terminal.

More details in the issue I raised.

@b3nThomas
Copy link
Author

@eahefnawy @ac360 @medikoo Sorry to tag you directly but you're the only contributors on this repo who have affiliations with the serverless org. Does anybody maintain this repo anymore and is this PR likely to get approved, or am I better off just forgetting it and using my own forked version?

Many thanks, Ben

@medikoo
Copy link
Contributor

medikoo commented Mar 10, 2022

@b3nThomas I suggest forking it. Thanks!

@b3nThomas
Copy link
Author

@medikoo Hmm ok. That's a shame...

@b3nThomas
Copy link
Author

b3nThomas commented Mar 15, 2022

Just an FYI but I've tried this out on my fork and it works nicely. You just get the message but without the starred border:

[2022-03-15T11:08:01.545Z]   site: 
[2022-03-15T11:08:01.545Z]     appUrl:         XXXXXXXX
[2022-03-15T11:08:01.545Z]     bucketName:     XXXXXXXX
[2022-03-15T11:08:01.545Z]     distributionId: XXXXXXXX
[2022-03-15T11:08:01.545Z] 
[2022-03-15T11:08:01.545Z]   
[2022-03-15T11:08:01.545Z]   Warning: You are using the beta version of Serverless Components. Please migrate to the GA version for enhanced features: https://github.com/serverless/components
[2022-03-15T11:08:01.545Z]   
[2022-03-15T11:08:01.545Z] 
[2022-03-15T11:08:01.545Z] 
[2022-03-15T11:08:01.545Z]   314s › site › done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Docker String.repeat error
2 participants