Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idempotent example aws node express #662

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Nsupyq
Copy link
Contributor

@Nsupyq Nsupyq commented Nov 5, 2021

As described in issue #661, this PR creates a new example about what is idempotent function and how to create idempotent functions.

@mnapoli
Copy link
Contributor

mnapoli commented Nov 6, 2021

Hi, I think the idea mentioned in #658 (comment) is to create your examples on your own repository. This new example is quite specific, I'm not sure if duplicating the existing examples make sense.

Again, examples are to get users started easily. Besides idempotence, there are many many topics that could be covered to make an application production ready. If we had an example for each topic we would have a lot of examples.

@Nsupyq
Copy link
Contributor Author

Nsupyq commented Nov 8, 2021

Ok, I will create examples on my own repository. How about adding a link of my repository in the README of aws-node-express-dynamodb-api?

@mnapoli
Copy link
Contributor

mnapoli commented Nov 8, 2021

You can add this to the community examples: https://github.com/serverless/examples#community-examples

@Nsupyq
Copy link
Contributor Author

Nsupyq commented Nov 11, 2021

Thank you. I will propose a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants