Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use font-config-sys 6.0 #246

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Use font-config-sys 6.0 #246

merged 1 commit into from
Jul 4, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jul 4, 2024

c.f. yeslogic/fontconfig-rs#40

crate cstr is now unmaintained. It hasnt been added to advisory-db yet.

@jayvdb jayvdb marked this pull request as ready for review July 4, 2024 02:21
mrobinson
mrobinson requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I think this should also include a major version bump for font-kit and add a rust-version = "1.77" line as the version necessary is quite new.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jul 4, 2024

I've bumped the minor version, as I guess that is what you wanted

@mrobinson mrobinson added this pull request to the merge queue Jul 4, 2024
Merged via the queue into servo:main with commit dbfe444 Jul 4, 2024
4 checks passed
@jayvdb jayvdb deleted the bump-fontconfig branch July 4, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayvdb @mrobinson