Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Make test_size test aware of target pointer width and "union" feature. #352

Merged
merged 1 commit into from
May 10, 2024

Conversation

zachs18
Copy link
Contributor

@zachs18 zachs18 commented May 10, 2024

Fixes #330.

Tested locally on x86-64-unknown-linux-gnu and i686-unknown-linux-gnu with and without --features union.

(This does assume that alignof(usize) == sizeof(usize) == alignof(ptr) == sizeof(ptr).)

Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbrubeck mbrubeck merged commit 03d9069 into servo:v1 May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants