-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fuzz crate #660
base: main
Are you sure you want to change the base?
Update fuzz crate #660
Conversation
Can you change your commits to (a) leave the username/password commit out of this PR, and (b) tell git about the rename of the fuzzing module? That would make it easier to confidently review this. |
Removed the debug commit and removed the fuzz target rename too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I think this target is being currently fuzzed. @DavidKorczynski does this change look OK to you? |
If this fuzz target is supposed to be run already then something is going wrong with that process seeing as me manually running it found a failing test case in a couple of seconds. |
The current fuzzer is being run by OSS-Fuzz and I can see there is also an assert bug listed on OSS-Fuzz. So I guess the question is whether the changes updated by @e00E are interesting to have - I think that's up to the maintainers to decide? To be clear though, the fuzzer will continue to be run by OSS-Fuzz if these gets merged in. |
Following the instructions from the fuzzing book the fuzz crate has been recreated. Putting the second parse and the assert on different lines gives better panic messages because it makes it easier to distinguish whether the unwrapping or the assert failed.
2eee845
to
55e65d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 81.70% 81.67% -0.03%
==========================================
Files 20 20
Lines 3547 3547
==========================================
- Hits 2898 2897 -1
- Misses 649 650 +1 ☔ View full report in Codecov by Sentry. |
Following the instructions from the fuzzing book the fuzz crate has been
recreated.
I renamed the file because it makes it slightly more clear what it does.
Putting the second parse and the assert on different lines gives better
panic messages because it makes it easier to distinguish whether the
unwrapping or the assert failed.
To run the fuzzer: