Only strip spaces from opaque path when both query and fragment are null #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current behavior, when `url.set_query(None)` is called to remove
the query from a opaque path, spaces are stripped even if a fragment
remains.
As the spec [1] says, strip spaces only when both the query and fragment
are null. For example:
```
let mut url = URL::parse("data:space ?query#hash");
url.set_query(None);
assert_eq!(url.as_str(), "data:space #hash")
```
[1]: https://url.spec.whatwg.org/#potentially-strip-trailing-spaces-from-an-opaque-path
ohno418
commented
Jun 14, 2023
Comment on lines
+1558
to
1559
| self.restore_already_parsed_fragment(fragment); | ||
| self.strip_trailing_spaces_from_opaque_path(); |
There was a problem hiding this comment.
Stripping spaces should only happen when the fragment is null, so the fragment should be restored first.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 82.44% 82.44%
=======================================
Files 20 20
Lines 3343 3349 +6
=======================================
+ Hits 2756 2761 +5
- Misses 587 588 +1
☔ View full report in Codecov by Sentry. |
|
I think this was fixed in #879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current behavior, when
url.set_query(None)is called to removethe query from a opaque path, spaces are stripped even if a fragment
remains.
As the spec 1 says, strip spaces only when both the query and fragment
are null. For example:
You can find the related test here:
https://github.com/web-platform-tests/wpt/pull/37556/files#diff-316fd17e018fdca0e399146c072ea3a95a08fe1ccd3f8fe940d73ca2b9d26c9eR57-R63