Added #[must_use] Attributes for Configuration Options #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
=======================================
Coverage 81.82% 81.82%
=======================================
Files 20 20
Lines 3532 3532
=======================================
Hits 2890 2890
Misses 642 642
☔ View full report in Codecov by Sentry. |
valenting
force-pushed
the
config/must-use
branch
from
3a9fc5a to
58bdc87
Compare
|
Thank you for the fix @Redfire75369 |
lucacasonato
approved these changes
Nov 9, 2023
|
Yeah I agree, would only break invalid uses |
montekki
referenced
this pull request
in matter-labs/zksync-withdrawal-finalizer
Nov 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [url](https://togithub.com/servo/rust-url) | workspace.dependencies | minor | `2.4.1` -> `2.5.0` | --- ### Release Notes <details> <summary>servo/rust-url (url)</summary> ### [`v2.5.0`](https://togithub.com/servo/rust-url/releases/tag/v2.5.0) [Compare Source](https://togithub.com/servo/rust-url/compare/v2.4.1...v2.5.0) #### What's Changed - Fix clippy by [@​valenting](https://togithub.com/valenting) in [https://github.com/servo/rust-url/pull/878](https://togithub.com/servo/rust-url/pull/878) - use checked addition to not panic in debug build by [@​Skgland](https://togithub.com/Skgland) in [https://github.com/servo/rust-url/pull/877](https://togithub.com/servo/rust-url/pull/877) - Fix search setting for non-special urls with space, query and fragment by [@​edgul](https://togithub.com/edgul) in [https://github.com/servo/rust-url/pull/879](https://togithub.com/servo/rust-url/pull/879) - Added #\[must_use] Attributes for Configuration Options by [@​Redfire75369](https://togithub.com/Redfire75369) in [https://github.com/servo/rust-url/pull/876](https://togithub.com/servo/rust-url/pull/876) - Correct spelling mistake in `Position` docs by [@​sprocklem](https://togithub.com/sprocklem) in [https://github.com/servo/rust-url/pull/875](https://togithub.com/servo/rust-url/pull/875) - Fix another overflow in punycode encode_into by [@​Skgland](https://togithub.com/Skgland) in [https://github.com/servo/rust-url/pull/880](https://togithub.com/servo/rust-url/pull/880) - Update url 2.5.0 by [@​valenting](https://togithub.com/valenting) in [https://github.com/servo/rust-url/pull/885](https://togithub.com/servo/rust-url/pull/885) #### New Contributors - [@​Skgland](https://togithub.com/Skgland) made their first contribution in [https://github.com/servo/rust-url/pull/877](https://togithub.com/servo/rust-url/pull/877) - [@​edgul](https://togithub.com/edgul) made their first contribution in [https://github.com/servo/rust-url/pull/879](https://togithub.com/servo/rust-url/pull/879) - [@​Redfire75369](https://togithub.com/Redfire75369) made their first contribution in [https://github.com/servo/rust-url/pull/876](https://togithub.com/servo/rust-url/pull/876) - [@​sprocklem](https://togithub.com/sprocklem) made their first contribution in [https://github.com/servo/rust-url/pull/875](https://togithub.com/servo/rust-url/pull/875) **Full Changelog**: servo/rust-url@v2.4.1...v2.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bors
referenced
this pull request
in rust-lang/cargo
Dec 1, 2023
](https://renovatebot.com){kind=link}
chore(deps): update compatible [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [clap](https://togithub.com/clap-rs/clap) | workspace.dependencies | patch | `4.4.7` -> `4.4.10` | | [core-foundation](https://togithub.com/servo/core-foundation-rs) | workspace.dependencies | patch | `0.9.3` -> `0.9.4` | | [ignore](https://togithub.com/BurntSushi/ripgrep/tree/master/crates/ignore) ([source](https://togithub.com/BurntSushi/ripgrep)) | workspace.dependencies | patch | `0.4.20` -> `0.4.21` | | [libc](https://togithub.com/rust-lang/libc) | workspace.dependencies | patch | `0.2.149` -> `0.2.150` | | [proptest](https://proptest-rs.github.io/proptest/proptest/index.html) ([source](https://togithub.com/proptest-rs/proptest)) | workspace.dependencies | minor | `1.3.1` -> `1.4.0` | | [regex](https://togithub.com/rust-lang/regex) | workspace.dependencies | minor | `1.9.3` -> `1.10.2` | | [serde](https://serde.rs) ([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies | patch | `1.0.190` -> `1.0.193` | | [similar](https://togithub.com/mitsuhiko/similar) | dev-dependencies | minor | `2.2.1` -> `2.3.0` | | [syn](https://togithub.com/dtolnay/syn) | workspace.dependencies | patch | `2.0.38` -> `2.0.39` | | [toml](https://togithub.com/toml-rs/toml) | workspace.dependencies | patch | `0.8.6` -> `0.8.8` | | [tracing-subscriber](https://tokio.rs) ([source](https://togithub.com/tokio-rs/tracing)) | workspace.dependencies | patch | `0.3.17` -> `0.3.18` | | [url](https://togithub.com/servo/rust-url) | workspace.dependencies | minor | `2.4.1` -> `2.5.0` | --- ### Release Notes <details> <summary>clap-rs/clap (clap)</summary> ### [`v4.4.10`](https://togithub.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#4410---2023-11-28) [Compare Source](https://togithub.com/clap-rs/clap/compare/v4.4.9...v4.4.10) ##### Documentation - Link out to changelog - Cross link derive's attribute reference to derive tutorial ### [`v4.4.9`](https://togithub.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#449---2023-11-27) [Compare Source](https://togithub.com/clap-rs/clap/compare/v4.4.8...v4.4.9) ##### Fixes - *(help)* Show correct `Command::about` under flattened headings - *(help)* Respect `hide` when flattening subcommands ### [`v4.4.8`](https://togithub.com/clap-rs/clap/blob/HEAD/CHANGELOG.md#448---2023-11-10) [Compare Source](https://togithub.com/clap-rs/clap/compare/v4.4.7...v4.4.8) ##### Features - Add `Command::flatten_help` to allow `git stash -h` like help for subcommands </details> <details> <summary>servo/core-foundation-rs (core-foundation)</summary> ### [`v0.9.4`](https://togithub.com/servo/core-foundation-rs/compare/core-foundation-v0.9.3...core-foundation-v0.9.4) [Compare Source](https://togithub.com/servo/core-foundation-rs/compare/core-foundation-v0.9.3...core-foundation-v0.9.4) </details> <details> <summary>rust-lang/libc (libc)</summary> ### [`v0.2.150`](https://togithub.com/rust-lang/libc/releases/tag/0.2.150) [Compare Source](https://togithub.com/rust-lang/libc/compare/0.2.149...0.2.150) #### What's Changed - feat: closefrom() and close_range() for FreeBSD by [`@​SteveLauC](https://togithub.com/SteveLauC)` in [https://github.com/rust-lang/libc/pull/3374](https://togithub.com/rust-lang/libc/pull/3374) - adding apple ifreq by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3375](https://togithub.com/rust-lang/libc/pull/3375) - Add pthread_once by [`@​0xcaff](https://togithub.com/0xcaff)` in [https://github.com/rust-lang/libc/pull/3376](https://togithub.com/rust-lang/libc/pull/3376) - netbsd: Add SO_NOSIGPIPE by [`@​taiki-e](https://togithub.com/taiki-e)` in [https://github.com/rust-lang/libc/pull/3377](https://togithub.com/rust-lang/libc/pull/3377) - Say goodbye to GH Pages in favor of docs.rs by [`@​JohnTitor](https://togithub.com/JohnTitor)` in [https://github.com/rust-lang/libc/pull/3378](https://togithub.com/rust-lang/libc/pull/3378) - bugfix for teeos use Option by [`@​Sword-Destiny](https://togithub.com/Sword-Destiny)` in [https://github.com/rust-lang/libc/pull/3379](https://togithub.com/rust-lang/libc/pull/3379) - openbsd/netbsd sharing execvpe definition by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3382](https://togithub.com/rust-lang/libc/pull/3382) - ifreq for apple follow-up fix case when in non libc_union case by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3385](https://togithub.com/rust-lang/libc/pull/3385) - NetBSD's mod.rs: fix cpuid_t definition. by [`@​he32](https://togithub.com/he32)` in [https://github.com/rust-lang/libc/pull/3386](https://togithub.com/rust-lang/libc/pull/3386) - ifconf addition to apple. fixing freebsd's implementation while at it. by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3388](https://togithub.com/rust-lang/libc/pull/3388) - adding exect/execvP for FreeBSD/DragonflyBSD by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3381](https://togithub.com/rust-lang/libc/pull/3381) - adding execvP for apple by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3383](https://togithub.com/rust-lang/libc/pull/3383) - adding ifreq struct for openbsd by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3384](https://togithub.com/rust-lang/libc/pull/3384) - Add `MCL_ONFAULT` constants by [`@​newpavlov](https://togithub.com/newpavlov)` in [https://github.com/rust-lang/libc/pull/3380](https://togithub.com/rust-lang/libc/pull/3380) - Add time namespace constant by [`@​cd-work](https://togithub.com/cd-work)` in [https://github.com/rust-lang/libc/pull/3352](https://togithub.com/rust-lang/libc/pull/3352) - adding few more CLONE_\* constant for Linux/Android. by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3034](https://togithub.com/rust-lang/libc/pull/3034) - android add handful lock free stdio calls by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3290](https://togithub.com/rust-lang/libc/pull/3290) - hurd: Fix msghdr's msg_iov field type by [`@​sthibaul](https://togithub.com/sthibaul)` in [https://github.com/rust-lang/libc/pull/3389](https://togithub.com/rust-lang/libc/pull/3389) - Adding missing macros from linux/if_tun.h by [`@​BrandonMFong](https://togithub.com/BrandonMFong)` in [https://github.com/rust-lang/libc/pull/3320](https://togithub.com/rust-lang/libc/pull/3320) - vxworks: Add mman.h consts and shm functions by [`@​jdygert-spok](https://togithub.com/jdygert-spok)` in [https://github.com/rust-lang/libc/pull/3406](https://togithub.com/rust-lang/libc/pull/3406) - Reenable FreeBSD 14 CI, and update definitions to match 14.0-RC1. by [`@​asomers](https://togithub.com/asomers)` in [https://github.com/rust-lang/libc/pull/3355](https://togithub.com/rust-lang/libc/pull/3355) - Use new check-cfg syntax in newer nightly by [`@​Urgau](https://togithub.com/Urgau)` in [https://github.com/rust-lang/libc/pull/3410](https://togithub.com/rust-lang/libc/pull/3410) - musl fixes and musl+riscv32 fixes by [`@​akiernan](https://togithub.com/akiernan)` in [https://github.com/rust-lang/libc/pull/3302](https://togithub.com/rust-lang/libc/pull/3302) - Add various constants from OpenBSD's sys/exec_elf.h. by [`@​ltratt](https://togithub.com/ltratt)` in [https://github.com/rust-lang/libc/pull/3409](https://togithub.com/rust-lang/libc/pull/3409) - riscv64/musl: Add landlock syscalls by [`@​marv](https://togithub.com/marv)` in [https://github.com/rust-lang/libc/pull/3398](https://togithub.com/rust-lang/libc/pull/3398) - Add stat64at function declaration to AIX by [`@​ecnelises](https://togithub.com/ecnelises)` in [https://github.com/rust-lang/libc/pull/3324](https://togithub.com/rust-lang/libc/pull/3324) - adding getmntinfo/getmntvinfo for DragonFlyBSD. by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3394](https://togithub.com/rust-lang/libc/pull/3394) - adding MOVE_MOUNT\* constants for linux to use with SYS_move_mount by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3391](https://togithub.com/rust-lang/libc/pull/3391) - freebsd adding PROT_MAX|PROT_MAX_EXTRACT mmap flags by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3399](https://togithub.com/rust-lang/libc/pull/3399) - linux/android adding few if_alg.h constants. by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3404](https://togithub.com/rust-lang/libc/pull/3404) - Setup Dependabot for GitHub Actions by [`@​JohnTitor](https://togithub.com/JohnTitor)` in [https://github.com/rust-lang/libc/pull/3411](https://togithub.com/rust-lang/libc/pull/3411) - For NetBSD: add entry for NetBSD/riscv64. by [`@​he32](https://togithub.com/he32)` in [https://github.com/rust-lang/libc/pull/3291](https://togithub.com/rust-lang/libc/pull/3291) - adding more recent pthread_get/setname_np calls to freebsd/dragonflybsd by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3412](https://togithub.com/rust-lang/libc/pull/3412) - NetBSD/mipsel: add support. by [`@​he32](https://togithub.com/he32)` in [https://github.com/rust-lang/libc/pull/3416](https://togithub.com/rust-lang/libc/pull/3416) - feat: add new constants from fanotify linux api by [`@​ad0](https://togithub.com/ad0)` in [https://github.com/rust-lang/libc/pull/3408](https://togithub.com/rust-lang/libc/pull/3408) - linux: add PTRACE_GETSIGMASK and PTRACE_SETSIGMASK by [`@​mbyzhang](https://togithub.com/mbyzhang)` in [https://github.com/rust-lang/libc/pull/3163](https://togithub.com/rust-lang/libc/pull/3163) - Add a few declarations for Apple systems by [`@​vincentisambart](https://togithub.com/vincentisambart)` in [https://github.com/rust-lang/libc/pull/3328](https://togithub.com/rust-lang/libc/pull/3328) - feat: Added ifconf struct by [`@​Brijeshkrishna](https://togithub.com/Brijeshkrishna)` in [https://github.com/rust-lang/libc/pull/3393](https://togithub.com/rust-lang/libc/pull/3393) - Upgrade Docker images to Ubuntu 23.10 by [`@​JohnTitor](https://togithub.com/JohnTitor)` in [https://github.com/rust-lang/libc/pull/3418](https://togithub.com/rust-lang/libc/pull/3418) - redox: Add remaining `grp.h` functions by [`@​ids1024](https://togithub.com/ids1024)` in [https://github.com/rust-lang/libc/pull/3421](https://togithub.com/rust-lang/libc/pull/3421) - netbsd/openbsd adding more accessors to siginfo_t. by [`@​devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3400](https://togithub.com/rust-lang/libc/pull/3400) - Prepare release for v0.2.150 by [`@​JohnTitor](https://togithub.com/JohnTitor)` in [https://github.com/rust-lang/libc/pull/3424](https://togithub.com/rust-lang/libc/pull/3424) #### New Contributors - [`@​0xcaff](https://togithub.com/0xcaff)` made their first contribution in [https://github.com/rust-lang/libc/pull/3376](https://togithub.com/rust-lang/libc/pull/3376) - [`@​he32](https://togithub.com/he32)` made their first contribution in [https://github.com/rust-lang/libc/pull/3386](https://togithub.com/rust-lang/libc/pull/3386) - [`@​sthibaul](https://togithub.com/sthibaul)` made their first contribution in [https://github.com/rust-lang/libc/pull/3389](https://togithub.com/rust-lang/libc/pull/3389) - [`@​BrandonMFong](https://togithub.com/BrandonMFong)` made their first contribution in [https://github.com/rust-lang/libc/pull/3320](https://togithub.com/rust-lang/libc/pull/3320) - [`@​jdygert-spok](https://togithub.com/jdygert-spok)` made their first contribution in [https://github.com/rust-lang/libc/pull/3406](https://togithub.com/rust-lang/libc/pull/3406) - [`@​Urgau](https://togithub.com/Urgau)` made their first contribution in [https://github.com/rust-lang/libc/pull/3410](https://togithub.com/rust-lang/libc/pull/3410) - [`@​akiernan](https://togithub.com/akiernan)` made their first contribution in [https://github.com/rust-lang/libc/pull/3302](https://togithub.com/rust-lang/libc/pull/3302) - [`@​marv](https://togithub.com/marv)` made their first contribution in [https://github.com/rust-lang/libc/pull/3398](https://togithub.com/rust-lang/libc/pull/3398) - [`@​ad0](https://togithub.com/ad0)` made their first contribution in [https://github.com/rust-lang/libc/pull/3408](https://togithub.com/rust-lang/libc/pull/3408) - [`@​vincentisambart](https://togithub.com/vincentisambart)` made their first contribution in [https://github.com/rust-lang/libc/pull/3328](https://togithub.com/rust-lang/libc/pull/3328) **Full Changelog**: rust-lang/libc@0.2.149...0.2.150 </details> <details> <summary>proptest-rs/proptest (proptest)</summary> ### [`v1.4.0`](https://togithub.com/proptest-rs/proptest/compare/v1.3.1...v1.4.0) [Compare Source](https://togithub.com/proptest-rs/proptest/compare/v1.3.1...v1.4.0) </details> <details> <summary>rust-lang/regex (regex)</summary> ### [`v1.10.2`](https://togithub.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#1102-2023-10-16) [Compare Source](https://togithub.com/rust-lang/regex/compare/1.10.1...1.10.2) \=================== This is a new patch release that fixes a search regression where incorrect matches could be reported. Bug fixes: - [BUG #​1110](https://togithub.com/rust-lang/regex/issues/1110): Revert broadening of reverse suffix literal optimization introduced in 1.10.1. ### [`v1.10.1`](https://togithub.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#1101-2023-10-14) [Compare Source](https://togithub.com/rust-lang/regex/compare/1.10.0...1.10.1) \=================== This is a new patch release with a minor increase in the number of valid patterns and a broadening of some literal optimizations. New features: - [FEATURE 04f5d7be](https://togithub.com/rust-lang/regex/commit/04f5d7be4efc542864cc400f5d43fbea4eb9bab6): Loosen ASCII-compatible rules such that regexes like `(?-u:☃)` are now allowed. Performance improvements: - [PERF 8a8d599f](https://togithub.com/rust-lang/regex/commit/8a8d599f9d2f2d78e9ad84e4084788c2d563afa5): Broader the reverse suffix optimization to apply in more cases. ### [`v1.10.0`](https://togithub.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#1100-2023-10-09) [Compare Source](https://togithub.com/rust-lang/regex/compare/1.9.6...1.10.0) \=================== This is a new minor release of `regex` that adds support for start and end word boundary assertions. That is, `\<` and `\>`. The minimum supported Rust version has also been raised to 1.65, which was released about one year ago. The new word boundary assertions are: - `\<` or `\b{start}`: a Unicode start-of-word boundary (`\W|\A` on the left, `\w` on the right). - `\>` or `\b{end}`: a Unicode end-of-word boundary (`\w` on the left, `\W|\z` on the right)). - `\b{start-half}`: half of a Unicode start-of-word boundary (`\W|\A` on the left). - `\b{end-half}`: half of a Unicode end-of-word boundary (`\W|\z` on the right). The `\<` and `\>` are GNU extensions to POSIX regexes. They have been added to the `regex` crate because they enjoy somewhat broad support in other regex engines as well (for example, vim). The `\b{start}` and `\b{end}` assertions are aliases for `\<` and `\>`, respectively. The `\b{start-half}` and `\b{end-half}` assertions are not found in any other regex engine (although regex engines with general look-around support can certainly express them). They were added principally to support the implementation of word matching in grep programs, where one generally wants to be a bit more flexible in what is considered a word boundary. New features: - [FEATURE #​469](https://togithub.com/rust-lang/regex/issues/469): Add support for `\<` and `\>` word boundary assertions. - [FEATURE(regex-automata) #​1031](https://togithub.com/rust-lang/regex/pull/1031): DFAs now have a `start_state` method that doesn't use an `Input`. Performance improvements: - [PERF #​1051](https://togithub.com/rust-lang/regex/pull/1051): Unicode character class operations have been optimized in `regex-syntax`. - [PERF #​1090](https://togithub.com/rust-lang/regex/issues/1090): Make patterns containing lots of literal characters use less memory. Bug fixes: - [BUG #​1046](https://togithub.com/rust-lang/regex/issues/1046): Fix a bug that could result in incorrect match spans when using a Unicode word boundary and searching non-ASCII strings. - [BUG(regex-syntax) #​1047](https://togithub.com/rust-lang/regex/issues/1047): Fix panics that can occur in `Ast->Hir` translation (not reachable from `regex` crate). - [BUG(regex-syntax) #​1088](https://togithub.com/rust-lang/regex/issues/1088): Remove guarantees in the API that connect the `u` flag with a specific HIR representation. `regex-automata` breaking change release: This release includes a `regex-automata 0.4.0` breaking change release, which was necessary in order to support the new word boundary assertions. For example, the `Look` enum has new variants and the `LookSet` type now uses `u32` instead of `u16` to represent a bitset of look-around assertions. These are overall very minor changes, and most users of `regex-automata` should be able to move to `0.4` from `0.3` without any changes at all. `regex-syntax` breaking change release: This release also includes a `regex-syntax 0.8.0` breaking change release, which, like `regex-automata`, was necessary in order to support the new word boundary assertions. This release also includes some changes to the `Ast` type to reduce heap usage in some cases. If you are using the `Ast` type directly, your code may require some minor modifications. Otherwise, users of `regex-syntax 0.7` should be able to migrate to `0.8` without any code changes. `regex-lite` release: The `regex-lite 0.1.1` release contains support for the new word boundary assertions. There are no breaking changes. ### [`v1.9.6`](https://togithub.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#196-2023-09-30) [Compare Source](https://togithub.com/rust-lang/regex/compare/1.9.5...1.9.6) \================== This is a patch release that fixes a panic that can occur when the default regex size limit is increased to a large number. - [BUG aa4e4c71](https://togithub.com/rust-lang/regex/commit/aa4e4c7120b0090ce0624e3c42a2ed06dd8b918a): Fix a bug where computing the maximum haystack length for the bounded backtracker could result underflow and thus provoke a panic later in a search due to a broken invariant. ### [`v1.9.5`](https://togithub.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#195-2023-09-02) [Compare Source](https://togithub.com/rust-lang/regex/compare/1.9.4...1.9.5) \================== This is a patch release that hopefully mostly fixes a performance bug that occurs when sharing a regex across multiple threads. Issue [#​934](https://togithub.com/rust-lang/regex/issues/934) explains this in more detail. It is [also noted in the crate documentation](https://docs.rs/regex/latest/regex/#sharing-a-regex-across-threads-can-result-in-contention). The bug can appear when sharing a regex across multiple threads simultaneously, as might be the case when using a regex from a `OnceLock`, `lazy_static` or similar primitive. Usually high contention only results when using many threads to execute searches on small haystacks. One can avoid the contention problem entirely through one of two methods. The first is to use lower level APIs from `regex-automata` that require passing state explicitly, such as [`meta::Regex::search_with`](https://docs.rs/regex-automata/latest/regex_automata/meta/struct.Regex.html#method.search_with). The second is to clone a regex and send it to other threads explicitly. This will not use any additional memory usage compared to sharing the regex. The only downside of this approach is that it may be less convenient, for example, it won't work with things like `OnceLock` or `lazy_static` or `once_cell`. With that said, as of this release, the contention performance problems have been greatly reduced. This was achieved by changing the free-list so that it was sharded across threads, and that ensuring each sharded mutex occupies a single cache line to mitigate false sharing. So while contention may still impact performance in some cases, it should be a lot better now. Because of the changes to how the free-list works, please report any issues you find with this release. That not only includes search time regressions but also significant regressions in memory usage. Reporting improvements is also welcome as well! If possible, provide a reproduction. Bug fixes: - [BUG #​934](https://togithub.com/rust-lang/regex/issues/934): Fix a performance bug where high contention on a single regex led to massive slow downs. ### [`v1.9.4`](https://togithub.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#194-2023-08-26) [Compare Source](https://togithub.com/rust-lang/regex/compare/1.9.3...1.9.4) \================== This is a patch release that fixes a bug where `RegexSet::is_match(..)` could incorrectly return false (even when `RegexSet::matches(..).matched_any()` returns true). Bug fixes: - [BUG #​1070](https://togithub.com/rust-lang/regex/issues/1070): Fix a bug where a prefilter was incorrectly configured for a `RegexSet`. </details> <details> <summary>serde-rs/serde (serde)</summary> ### [`v1.0.193`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.193) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.192...v1.0.193) - Fix field names used for the deserialization of `RangeFrom` and `RangeTo` ([#​2653](https://togithub.com/serde-rs/serde/issues/2653), [#​2654](https://togithub.com/serde-rs/serde/issues/2654), [#​2655](https://togithub.com/serde-rs/serde/issues/2655), thanks [`@​emilbonnek](https://togithub.com/emilbonnek))` ### [`v1.0.192`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.192) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.191...v1.0.192) - Allow internal tag field in untagged variant ([#​2646](https://togithub.com/serde-rs/serde/issues/2646), thanks [`@​robsdedude](https://togithub.com/robsdedude))` ### [`v1.0.191`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.191) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.190...v1.0.191) - Documentation improvements </details> <details> <summary>mitsuhiko/similar (similar)</summary> ### [`v2.3.0`](https://togithub.com/mitsuhiko/similar/blob/HEAD/CHANGELOG.md#230) [Compare Source](https://togithub.com/mitsuhiko/similar/compare/2.2.1...2.3.0) - Added support for `Change::value_ref` and `Change::value_mut`. </details> <details> <summary>dtolnay/syn (syn)</summary> ### [`v2.0.39`](https://togithub.com/dtolnay/syn/releases/tag/2.0.39) [Compare Source](https://togithub.com/dtolnay/syn/compare/2.0.38...2.0.39) - Fix parsing of return expression in match guards ([#​1528](https://togithub.com/dtolnay/syn/issues/1528)) - Improve error message on labeled loop as value expression for break ([#​1531](https://togithub.com/dtolnay/syn/issues/1531)) </details> <details> <summary>toml-rs/toml (toml)</summary> ### [`v0.8.8`](https://togithub.com/toml-rs/toml/compare/toml-v0.8.7...toml-v0.8.8) [Compare Source](https://togithub.com/toml-rs/toml/compare/toml-v0.8.7...toml-v0.8.8) ### [`v0.8.7`](https://togithub.com/toml-rs/toml/compare/toml-v0.8.6...toml-v0.8.7) [Compare Source](https://togithub.com/toml-rs/toml/compare/toml-v0.8.6...toml-v0.8.7) </details> <details> <summary>tokio-rs/tracing (tracing-subscriber)</summary> ### [`v0.3.18`](https://togithub.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.18): tracing-subscriber 0.3.18 [Compare Source](https://togithub.com/tokio-rs/tracing/compare/tracing-subscriber-0.3.17...tracing-subscriber-0.3.18) This release of `tracing-subscriber` adds support for the [`NO_COLOR`][NO_COLOR] environment variable (an informal standard to disable emitting ANSI color escape codes) in `fmt::Layer`, reintroduces support for the [`chrono`][chrono] crate, and increases the minimum supported Rust version (MSRV) to Rust 1.63.0. It also introduces several minor API improvements. ##### Added - **chrono**: Add [`chrono`][chrono] implementations of `FormatTime` ([#​2690]) - **subscriber**: Add support for the [`NO_COLOR`][NO_COLOR] environment variable in `fmt::Layer` ([#​2647]) - **fmt**: make `format::Writer::new()` public ([#​2680]) - **filter**: Implement `layer::Filter` for `Option<Filter>` ([#​2407]) ##### Changed - **log**: bump version of `tracing-log` to 0.2 ([#​2772]) - Increased minimum supported Rust version (MSRV) to 1.63.0+. [`chrono`]: https://togithub.com/chronotope/chrono [`NO_COLOR`]: https://no-color.org/ [#​2690]: https://togithub.com/tokio-rs/tracing/pull/2690 [#​2647]: https://togithub.com/tokio-rs/tracing/pull/2647 [#​2680]: https://togithub.com/tokio-rs/tracing/pull/2680 [#​2407]: https://togithub.com/tokio-rs/tracing/pull/2407 [#​2772]: https://togithub.com/tokio-rs/tracing/pull/2772 Thanks to [`@​shayne-fletcher](https://togithub.com/shayne-fletcher),` [`@​dmlary](https://togithub.com/dmlary),` [`@​kaifastromai](https://togithub.com/kaifastromai),` and [`@​jsgf](https://togithub.com/jsgf)` for contributing! </details> <details> <summary>servo/rust-url (url)</summary> ### [`v2.5.0`](https://togithub.com/servo/rust-url/releases/tag/v2.5.0) [Compare Source](https://togithub.com/servo/rust-url/compare/v2.4.1...v2.5.0) #### What's Changed - Fix clippy by [`@​valenting](https://togithub.com/valenting)` in [https://github.com/servo/rust-url/pull/878](https://togithub.com/servo/rust-url/pull/878) - use checked addition to not panic in debug build by [`@​Skgland](https://togithub.com/Skgland)` in [https://github.com/servo/rust-url/pull/877](https://togithub.com/servo/rust-url/pull/877) - Fix search setting for non-special urls with space, query and fragment by [`@​edgul](https://togithub.com/edgul)` in [https://github.com/servo/rust-url/pull/879](https://togithub.com/servo/rust-url/pull/879) - Added #\[must_use] Attributes for Configuration Options by [`@​Redfire75369](https://togithub.com/Redfire75369)` in [https://github.com/servo/rust-url/pull/876](https://togithub.com/servo/rust-url/pull/876) - Correct spelling mistake in `Position` docs by [`@​sprocklem](https://togithub.com/sprocklem)` in [https://github.com/servo/rust-url/pull/875](https://togithub.com/servo/rust-url/pull/875) - Fix another overflow in punycode encode_into by [`@​Skgland](https://togithub.com/Skgland)` in [https://github.com/servo/rust-url/pull/880](https://togithub.com/servo/rust-url/pull/880) - Update url 2.5.0 by [`@​valenting](https://togithub.com/valenting)` in [https://github.com/servo/rust-url/pull/885](https://togithub.com/servo/rust-url/pull/885) #### New Contributors - [`@​Skgland](https://togithub.com/Skgland)` made their first contribution in [https://github.com/servo/rust-url/pull/877](https://togithub.com/servo/rust-url/pull/877) - [`@​edgul](https://togithub.com/edgul)` made their first contribution in [https://github.com/servo/rust-url/pull/879](https://togithub.com/servo/rust-url/pull/879) - [`@​Redfire75369](https://togithub.com/Redfire75369)` made their first contribution in [https://github.com/servo/rust-url/pull/876](https://togithub.com/servo/rust-url/pull/876) - [`@​sprocklem](https://togithub.com/sprocklem)` made their first contribution in [https://github.com/servo/rust-url/pull/875](https://togithub.com/servo/rust-url/pull/875) **Full Changelog**: servo/rust-url@v2.4.1...v2.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rust-lang/cargo). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues similar to Redfire75369/spiderfire#35, where the updated
ParseOptionsisn't used since it isCopy.