refactor and add tests for percent encoding

[joshka]

• refactor: move AsciiSet related code to ascii_set.rs
• Add tests for percent_encoding

[Manishearth]

CI fails

warning: `percent-encoding` (lib) generated 1 warning
error: there is no argument named `i`
   --> percent_encoding/src/lib.rs:376:50
    |
376 |             assert_eq!(encoded, alloc::format!("%{i:02X}"));
    |                                                  ^^^^^^^

[codecov]

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6050a6e). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
percent_encoding/src/ascii_set.rs	87.50%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage        ?   82.27%           
=======================================
  Files           ?       22           
  Lines           ?     3560           
  Branches        ?        0           
=======================================
  Hits            ?     2929           
  Misses          ?      631           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshka]

CI fails

warning: `percent-encoding` (lib) generated 1 warning
error: there is no argument named `i`
   --> percent_encoding/src/lib.rs:376:50
    |
376 |             assert_eq!(encoded, alloc::format!("%{i:02X}"));
    |                                                  ^^^^^^^

Taking a look. This is a failure when using 1.56 which I'm assuming has some different semantics on format! than more modern rust versions.

QQ relating to tests. I wasn't entirely sure whether I was doing the right thing with feature flags on alloc for the tests. Does it seem right?

Aside: CI doesn't continue the other matrix versions. It might be useful to do that to see any other failures / general success.

[Manishearth]

This is a failure when using 1.56 which I'm assuming has some different semantics on format! than more modern rust versions.

Yeah, the ability to reference local variables in format-strings is new.

QQ relating to tests. I wasn't entirely sure whether I was doing the right thing with feature flags on alloc for the tests. Does it seem right?

using alloc::format seems fine. I don't see that you added any feature flags