Test MSRV with idna unicode-rs back end and test ICU4X back end with 1.67 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## idna-v1x #986 +/- ##
============================================
+ Coverage 80.48% 80.50% +0.02%
============================================
Files 24 24
Lines 4253 4253
============================================
+ Hits 3423 3424 +1
+ Misses 830 829 -1 ☔ View full report in Codecov by Sentry. |
|
Is it excessive to run the MSRV (1.57.0) on Mac and Windows? Should those be excluded to make the MSRV test Ubuntu-only? |
hsivonen
requested review from
valenting and
Manishearth
and removed request for
valenting
Manishearth
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add idna_adapter awareness to CI. (The no-unicode branch of idna_adapter does not make sense to test here, since it obviously fails normal tests.)