Make the port of Origin be an Option<u16>
#989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL specification changed in 2016 [1] [2] such that now the origin's port should be the same as the URL's port. This means that the port can `None` in the case that it is the default port for a scheme. 1. whatwg/url@b0e4def 2. whatwg/html#870 Fixes #821.
3 tasks
|
Is this not a breaking change? |
Yes, I think it is. I've tried to add the breaking change label. |
|
oh, duh. didn't notice that. The change itself seems good, I imagine we have to leave this PR open until we're ready to make breaking changes again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL specification changed in 2016 1 2 such that now the origin's port
should be the same as the URL's port. This means that the port can
Nonein the case that it is the default port for a scheme.Fixes #821.
Footnotes
https://github.com/whatwg/url/commit/b0e4def5b62e0be2d75b4b7b5720a5e0ea879596 ↩
https://github.com/whatwg/html/pull/870 ↩