RestyleDamage: Ensure correctness with externally set bits#225
Open
nicoburns wants to merge 9 commits intoservo:mainfrom
Open
RestyleDamage: Ensure correctness with externally set bits#225nicoburns wants to merge 9 commits intoservo:mainfrom
nicoburns wants to merge 9 commits intoservo:mainfrom
Conversation
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 22df130 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
There is no point in setting this flag to true when it's no longer doing anything, `transition-behavior` is now enabled unconditionally. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
…servo#222) * Simplify restyle damage macros Signed-off-by: Nico Burns <nico@nicoburns.com> * Don't diff custom properties if we've already set damage anyway Signed-off-by: Nico Burns <nico@nicoburns.com> --------- Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Loirooriol
reviewed
Aug 7, 2025
Collaborator
Loirooriol
left a comment
Loirooriol
left a comment
There was a problem hiding this comment.
IIRC in some places we were using truncate() or such to remove external bits. Seems your patch would break that.
Collaborator
Author
We don't seem to be doing that currently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure's that methods defined by the
bitflagscrate (all,contains,empty, etc) take into account the possibility of externally set bits. See: https://docs.rs/bitflags/latest/bitflags/#externally-defined-flags