Removed euclid dependency, while allowing for more math functions. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avr1
force-pushed
the
master
branch
3 times, most recently
from
37e246a
to
8551ea7
Compare
|
I'm confused what happened here - I thought we were only replacing the uses of Point2D and Size2D in surfman; there should be no need to import all the other unused types from euclid. The code in the examples that uses other euclid types can continue to use euclid; we can change the dependency to a dev-dependency in the Cargo.toml instead. |
|
That makes much more sense. Sorry. I'll close this and fix some of the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #208. This is a lot of code, so please review carefully. Thanks!