Use cstr literals where possible #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine though it seems the build is failing on Windows. |
|
I suspect c strings are i8 on windows? It's a common cross-platform error. |
jschwe
force-pushed
the
jschwender/c_str
branch
4 times, most recently
from
c1e2639
to
ada53a2
Compare
Convert usage of byte str and normal str with a `\0` to cstr literals where possible. Since CStr::as_ptr() returns `*const c_char` this also allows removing a nice amount of pointer casts. On Windows this also allows removing casts to [`LPCSTR`], which is defined as a `*const CHAR`, where `CHAR` is defined as `c_char` and `c_char` is taken from the std library if the `std` feature is enabled. [`LPCSTR`]: https://docs.rs/winapi/latest/winapi/um/winnt/type.LPCSTR.html Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
Fixes pedantic clippy lint `ptr_as_ptr`. Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
jschwe
force-pushed
the
jschwender/c_str
branch
2 times, most recently
from
ad7ebbd
to
ab6cd30
Compare
Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
jschwe
force-pushed
the
jschwender/c_str
branch
from
ab6cd30
to
b2a30a1
Compare
The nice thing about While removing those needless casts, I stumbled a bit over CreateWindowExA accepting a |
jdm
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert usage of byte str and normal str with a
\0to cstr literals where possible