Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sparkle with glow #318

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Replace sparkle with glow #318

merged 1 commit into from
Oct 10, 2024

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Sep 25, 2024

sparkle is a GL crate that is part of the Servo project, but mostly unmaintained. We would like to archive it and replace it with glow, that is actively maintained and used by wgpu and the wider Rust community.

Part of servo/servo#33539

@mrobinson
Copy link
Member

Nice! I think it would be really useful here to give a bit of background on sparkle and glow in the PR description and why we are replacing one for the other.

src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
@sagudev sagudev marked this pull request as ready for review September 25, 2024 09:52
src/chains.rs Outdated Show resolved Hide resolved
src/chains.rs Outdated Show resolved Hide resolved
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev
Copy link
Member Author

sagudev commented Oct 10, 2024

This is breaking change and it will need version bump!

@mrobinson mrobinson added this pull request to the merge queue Oct 10, 2024
Merged via the queue into servo:main with commit 7a2918d Oct 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants