Skip to content

Comments

Increase api call timeout to 120 seconds#91

Merged
sherwindayupay merged 1 commit intomainfrom
timout_increase
Feb 9, 2026
Merged

Increase api call timeout to 120 seconds#91
sherwindayupay merged 1 commit intomainfrom
timout_increase

Conversation

@alexgolod
Copy link
Contributor

No description provided.

@alexgolod alexgolod changed the title Increase api cal timout to 120 seconds Increase api call timeout to 120 seconds Feb 6, 2026
@alvaro-vinuela alvaro-vinuela self-requested a review February 6, 2026 15:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request increases the default API call timeout from 30 seconds to 120 seconds for CMON API requests. The change addresses the need for longer timeout periods when communicating with CMON controllers, which can be helpful for slower network conditions or longer-running API operations.

Changes:

  • Increased default timeout value from 30 to 120 seconds in the Config defaults
  • Improved struct field alignment in CmonInstance for better code readability
  • Removed trailing whitespace from multiple lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FetchBackupDays: 7,
FetchJobsHours: 12,
Timeout: 30,
Timeout: 120,
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout default value has been changed from 30 to 120 seconds, but the documentation in README.md line 169 still states "Default 30". The documentation should be updated to reflect this new default value of 120 seconds.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🤖 Patch PR created: #92 targeting release-2.4.0

@sherwindayupay sherwindayupay merged commit d36896c into main Feb 9, 2026
9 checks passed
@sherwindayupay sherwindayupay deleted the timout_increase branch February 9, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants