Fix critical security vulnerabilities (command injection and XSS) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses HIGH SEVERITY security issues identified by CodeQL:
1. Command Injection (apps.js:229-237):
- Replaced exec() with spawn() to prevent command injection
- User-controlled app.path no longer goes through shell interpreter
- Added proper process detachment and error handling
2. XSS Vulnerabilities (multiple files):
- Added escapeHtml() utility function to sanitize user-controlled data
- Fixed innerHTML injections in:
* ui-components.js - app names, categories, icon filenames
* navigation.js - category names and icon filenames
* heatmap.js - app names in labels
* app-details.js - icon filenames
- All user-controlled data (app names, category names, file paths) is now
properly escaped before being inserted into innerHTML
Security improvements prevent arbitrary code execution from:
- Malicious application paths stored in database
- Crafted app names or categories containing script tags
- Icon filenames with XSS payloads
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sanitize user-controlled data in analytics page: - App names in top apps list - App names in all applications grid - Category names in category breakdown - Icon filenames in image sources 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sanitize app name in longest session insight display. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Set publish to null to prevent electron-builder from trying to publish to GitHub releases during local builds. This prevents the GH_TOKEN error. Publishing is handled separately by the release.yml workflow. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added CSC_IDENTITY_AUTO_DISCOVERY: false to ci.yml - Added CSC_IDENTITY_AUTO_DISCOVERY: false to release.yml - Reverted publish: null from package.json to allow releases - Re-added ZIP target for releases This prevents code signing errors while still allowing the release workflow to upload builds to GitHub releases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
electron-builder will no longer try to auto-publish to GitHub. Release workflow uses softprops/action-gh-release to attach builds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses HIGH SEVERITY security issues identified by CodeQL:
Command Injection (apps.js:229-237):
XSS Vulnerabilities (multiple files):
Security improvements prevent arbitrary code execution from:
🤖 Generated with Claude Code