Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JADX decompiler #27

Merged
merged 11 commits into from
Mar 10, 2024
Merged

Add JADX decompiler #27

merged 11 commits into from
Mar 10, 2024

Conversation

NebelNidas
Copy link
Contributor

@NebelNidas NebelNidas commented Mar 30, 2023

JADX is a bit on the slower side of things, but once we allow it to properly cache decompiled classes, it should get a lot faster. Edit: After my refactoring in 4201b1e, it's actually quite fast!
Code quality is generally quite good, and it's needed for when I eventually add a Dalvik bytecode backend, as JADX is the only Dalvik to Java decompiler available right now.

Depends on #29, because JADX will crash without SLF4J present.

@js6pak
Copy link

js6pak commented Nov 1, 2023

as JADX is the only Dalvik to Java decompiler available right now

You can use https://github.com/Col-E/dex-translator or https://github.com/pxb1988/dex2jar to convert dex to jar and then use a normal java decompiler.

Speeds up things significantly. And yes, the memory is never reclaimed, but once we move the cache to the disk instead, that won't be an issue anymore
Now only passes the requested class instead of all input files.
@NebelNidas NebelNidas marked this pull request as ready for review March 10, 2024 20:45
@sfPlayer1 sfPlayer1 merged commit 2cb3bbd into sfPlayer1:master Mar 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants