About page #224
About page #224
Conversation
| @@ -10,7 +10,7 @@ export const requiresLogin = | |||
| const { status } = useSession(); | |||
|
|
|||
| // Include any public pathnames here | |||
| const publicPaths = ["/signInPage"]; | |||
| const publicPaths = ["/signInPage", "/about"]; | |||
There was a problem hiding this comment.
Good job here. Since the app has been updated to include middleware, in "Middleware.ts", please pull down and merge that code with this, and then add it to the matcher in the RegEx in the file so it's not a blocker for those who are not signed in.
src/components/navbar/NavBar.tsx
Outdated
| @@ -46,6 +47,11 @@ const NavBar = () => { | |||
| <p className={$navbar.linkTitle}>Settings</p> | |||
| </Link> | |||
| <br /> | |||
| <Link href="/about" className={$navbar.link}> | |||
| <Info className={$navbar.icon} /> | |||
There was a problem hiding this comment.
Please be sure you are adding the property types to the appropriate .css.d.ts file - and fix some of the "any" type errors.
src/pages/about.tsx
Outdated
| tracking goals for students with disabilities. | ||
| </div> | ||
| <div></div> | ||
| </> |
There was a problem hiding this comment.
Is there a reason we have the fragments instead of divs? (It makes it easier to apply CSS if they are specific elements rather than fragments.)
Minor cleanup request - please remove extra code we are not currently using, like the imports and empty div - we can add needed imports and components later.
Good job - this is a good starting point.
There was a problem hiding this comment.
Nice work, @shin101 and @SeldomseenSchweig ! This is a great starting point for the About page.
|
We can add more functionality and text to this, but since I have not heard from either of you I will go ahead and merge this. Thanks for working on it. |
this page describes the app and it's purpose. It is gotten to through the Compass logo