Add breadcrumbs #268
Merged
Add breadcrumbs #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hieungo89
commented
Nov 21, 2023
•
hieungo89
commented
- Added a simple breadcrumbs layout using the address bar.
- Refactored some of the navbar logic grouping desktop view and mobile/tablet view.
…mbsNav. Extract CSS to its own file.
codetheweb
reviewed
Nov 29, 2023
tessathornberry
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Nice work, @hieungo89 ! You could go back and look at the linting comments, etc in https://github.com/sfbrigade/compass/pull/268/files if you like, but the functionality is good.
| // An array of breadcrumbs fixed to students/staff as the first index. This will be modified depending on how the address bar will be displayed. | ||
| const breadcrumbs = paths.map((path, index) => { | ||
| if (index === 0) return ""; | ||
| if (index % 2 === 1) { |
There was a problem hiding this comment.
I think these conditionals are good for now - once we get more path links, like STUDENTS / Student Name / Goal / Benchmark (for data visualization), like you say in the documentation/comments, we can add for those cases
.
| </Box> | ||
| {desktop ? ( | ||
| <> | ||
| {/* Sidebar for screens & breadcrumbs > md size */} |
There was a problem hiding this comment.
Good comment/documentation
codetheweb
approved these changes
Dec 12, 2023
hieungo89
added a commit
that referenced
this pull request
Feb 13, 2024
hieungo89
added a commit
that referenced
this pull request
Feb 14, 2024
* Add user to the staff list on the frontend instead of the backend * [Closes #221] Update dependencies, resolve all npm audit warnings (#259) * Ran npm audit fix * Remove deprecated @next/font * Replace mockery with rewiremock * Bump nextjs version * Bump typed-css-modules version * Staff page (#269) Co-authored-by: Brandon Cruz-Youll <brandon.cruzyoull@gmail.com> * Add breadcrumbs (#268) * changed placeholder to defaultValue on forms for edit student and edit staff (#276) * added placeholder files and instruction documentation for Design System components and their css modules (#275) * Update button module to override MUI styling and apply to all button instances (#277) * fix secondary button styling on button module and apply to edit button on student page * add button folder with button module to components * change imports for button module * fix edit, cancel, and save buttons on student page * replace button module file in design system button folder and delete previous button folder * replace import statements for button module * change subgoal button to inherit button module styling instead of goal module styling * change assign staff button styling in subgoal to inherit button module styling * update buttons on subgoal assignment modal to inherit button module styling * update border radius and secondary border color in button module * change all button stylings on staff page * changes to button module * prettier fix * update primary variable hex in global css file and update button color to be in accordance with DS * fix prettier in globalcss * remove sx from line 43 of staff/[user_id] and remove all instances of home.bold styling in buttons --------- * Fix cm student id page (#280) * add Goal and Iep components and css from feat-cm-edit-goal * remove css class in Goal.module.css for removed controlCarat class * add flexWrap: wrap to div containing benchmark info in goal to avoid pushing ArrowForwardIosIcon into Add Goal form * run prettier * remove additional unused code and imports from components/goal/Goal * Fix type error --------- Co-authored-by: Francis Li <francisli@users.noreply.github.com> Co-authored-by: Brett Austin Eastman <76603041+BrettEastman@users.noreply.github.com> Co-authored-by: Brandon Cruz-Youll <brandon.cruzyoull@gmail.com> Co-authored-by: Hieu Ngo <hieu.ngo12989@gmail.com> Co-authored-by: Brandon Cruz-Youll <42663258+BeeSeeWhy@users.noreply.github.com> Co-authored-by: Tessa Thornberry <tthornberryclass@gmail.com> Co-authored-by: Hannah McGowan <73210740+hannahmcg@users.noreply.github.com> Co-authored-by: KCCPMG <39074889+KCCPMG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.