Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kenny/feat depends #8

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Kenny/feat depends #8

merged 2 commits into from
Dec 28, 2024

Conversation

kennethdsheridan
Copy link
Collaborator

Makefile: Conditional Docker Usage & Numactl Install

Changes:

  1. Use Docker for cross-compiling Linux binaries only if on macOS, Docker is installed, and running.
  2. Add numactl installation check on Linux in install-tools to ensure system compatibility.

Why:

  • Prevent failures on macOS when Docker isn't running.
  • Ensure numactl is available for proper hardware reporting on Linux.

@kennethdsheridan kennethdsheridan added the enhancement New feature or request label Dec 28, 2024
@kennethdsheridan kennethdsheridan self-assigned this Dec 28, 2024
@kennethdsheridan kennethdsheridan merged commit ee299b2 into main Dec 28, 2024
1 check passed
@kennethdsheridan kennethdsheridan deleted the kenny/feat_depends branch December 28, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennethdsheridan kennethdsheridan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kennethdsheridan