Skip to content

Commit

Permalink
Drop support for Ruby 3.0
Browse files Browse the repository at this point in the history
  • Loading branch information
sferik committed Apr 30, 2024
1 parent 1a7e9af commit eec72c5
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.0', '3.1', '3.2', '3.3']
ruby-version: ['3.1', '3.2', '3.3']

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require:

AllCops:
NewCops: enable
TargetRubyVersion: 3.0
TargetRubyVersion: 3.1

Layout/ArgumentAlignment:
EnforcedStyle: with_fixed_indentation
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ then Nokogiri, and finally REXML.
This library aims to support and is tested against the following Ruby
implementations:

* 3.0
* 3.1
* 3.2
* 3.3

If something doesn't work on one of these versions, it's a bug.

Expand Down
2 changes: 1 addition & 1 deletion lib/multi_xml.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def initialize(type)
"decimal" => proc { |number| BigDecimal(number) },
"boolean" => proc { |boolean| !%w[0 false].include?(boolean.strip) },
"string" => proc { |string| string.to_s },
"yaml" => proc { |yaml| YAML.load(yaml) rescue yaml }, # rubocop:disable Style/RescueModifier, Security/YAMLLoad
"yaml" => proc { |yaml| YAML.load(yaml) rescue yaml }, # rubocop:disable Style/RescueModifier
"base64Binary" => proc { |binary| base64_decode(binary) },
"binary" => proc { |binary, entity| parse_binary(binary, entity) },
"file" => proc { |file, entity| parse_file(file, entity) }
Expand Down
2 changes: 1 addition & 1 deletion multi_xml.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
spec.summary = "Provides swappable XML backends utilizing LibXML, Nokogiri, Ox, or REXML."
spec.homepage = "https://github.com/sferik/multi_xml"
spec.license = "MIT"
spec.required_ruby_version = ">= 3.0"
spec.required_ruby_version = ">= 3.1.4"

This comment has been minimized.

Copy link
@frenkel

frenkel May 1, 2024

This will prevent installation on Debian stable, which is still using (a patched) 3.1.2. Maybe change it to >= 3.1.0?

This comment has been minimized.

Copy link
@sferik

sferik May 1, 2024

Author Owner

Version 3.1.2 has known security vulnerabilities. Is there anything preventing those on Debian stable from upgrading to a newer version?

This comment has been minimized.

Copy link
@xeron

xeron May 1, 2024

I'm facing this problem right now:

bundle stderr: multi_xml-0.7.0 requires ruby version >= 3.1.4, which is incompatible with the current version, 3.1.2

I believe Debian maintainers almost never update the version until the next major OS release, they import security patches and patch sources during the build process.

This comment has been minimized.

Copy link
@frenkel

frenkel May 1, 2024

Yeah, they add some patch level after the version number, for example 3.1.2p20.

This comment has been minimized.

Copy link
@sferik

sferik May 1, 2024

Author Owner

Okay, I will release version 0.7.1 with a relaxed required Ruby version constraint to accommodate Debian stable.

This comment has been minimized.

Copy link
@frenkel

frenkel May 1, 2024

Thank you very much!


spec.metadata["allowed_push_host"] = "https://rubygems.org"

Expand Down

0 comments on commit eec72c5

Please sign in to comment.