Skip to content

Commit

Permalink
fix: fmt
Browse files Browse the repository at this point in the history
Signed-off-by: Sam Gammon <sam@elide.ventures>
  • Loading branch information
sgammon committed Sep 19, 2024
1 parent 930f332 commit f20bc50
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 11 deletions.
1 change: 0 additions & 1 deletion .github/DCO.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:
Expand Down
1 change: 0 additions & 1 deletion .github/PROJECT.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

## GraalVM Rules for Bazel

> Project Structure & Governance
Expand Down
11 changes: 4 additions & 7 deletions docs/maven-artifacts.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@

## Using GraalVM artifacts from Maven

Several important GraalVM artifacts are distributed via Maven, including the GraalVM SDK, Truffle API, and others.

These rules have some macros which make use of this libraries a bit easier, particularly via [`rules_jvm_external`][1].


### Installing a Maven artifact

**From a `WORKSPACE.bazel`:**

```python
# ... setup code for `rules_jvm_external` ...
# ... setup code for `rules_graalvm` ...
Expand All @@ -17,6 +16,7 @@ load("@rules_graalvm//graalvm/artifacts:maven.bzl", "graalvm")
load("@rules_jvm_external//:defs.bzl", "maven_install")
load("@rules_jvm_external//:specs.bzl", "maven")
```

```python
maven_install(
artifacts = [
Expand All @@ -32,6 +32,7 @@ maven_install(
> **What this does:** The `graalvm.artifact` call will add the `graalvm.catalog.SDK` artifact via the `maven` struct provided by `rules_jvm_external`.
This is equivalent to the normal arguments expected by `maven_install`:

```python
maven_install(
artifacts = [
Expand All @@ -40,7 +41,6 @@ maven_install(
)
```


### Using a Maven artifact

In addition to the macro made available for use in the `WORKSPACE` file, there is also a macro which makes it easy to use these Maven artifacts in your `java_library(deps = *)`:
Expand All @@ -62,20 +62,17 @@ java_library(
)
```


## Available Maven dependencies


| Artifact | Catalog symbol | Maven coordinate | Notes |
| ---------------- | --------------------- | -------------------------------------- | --------------------------------------------- |
| [GraalVM SDK][2] | `catalog.SDK` | [`org.graalvm.sdk:graal-sdk`][3] | Main GraalVM SDK package |
| [Truffle API][4] | `catalog.TRUFFLE` | [`org.graalvm.truffle:truffle-api`][5] | API package for Truffle language implementors |
| [Truffle NFI][6] | `catalog.TRUFFLE.NFI` | [`org.graalvm.truffle:truffle-nfi`][7] | Native Function Interface package or Truffle |


[1]: https://github.com/bazelbuild/rules_jvm_external
[2]: https://www.graalvm.org/sdk/javadoc/
[3]: https://search.maven.org/artifact/org.graalvm.sdk/graal-sdk
[3]: https://search.maven.org/artifact/org.graalvm.sdk/graal-sdk
[4]: https://www.graalvm.org/truffle/javadoc/com/oracle/truffle/api/package-summary.html
[5]: https://search.maven.org/artifact/org.graalvm.truffle/truffle-api
[6]: https://github.com/oracle/graal/blob/master/truffle/docs/NFI.md
Expand Down
2 changes: 1 addition & 1 deletion internal/native_image/classic.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _graal_binary_classic_implementation(ctx):
)

if ctx.files.data:
direct_inputs.extend(ctx.files.data)
direct_inputs.extend(ctx.files.data)

inputs = depset(
direct_inputs,
Expand Down
2 changes: 1 addition & 1 deletion internal/native_image/rules.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def _graal_binary_implementation(ctx):
)

if ctx.files.data:
direct_inputs.extend(ctx.files.data)
direct_inputs.extend(ctx.files.data)

# assemble final inputs
inputs = depset(
Expand Down

0 comments on commit f20bc50

Please sign in to comment.