Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource configuration file flag #308

Merged

Conversation

loganasherjones
Copy link
Contributor

@loganasherjones loganasherjones commented Feb 19, 2024

This add the resource_configuration flag to the native_image rule.

This allows users to use the output of the tracer to include the resource specified in the runtime.

Before this PR can be merged, I had to fix with this PR so it is rebased from that branch.

This PR address this feature

Signed-off-by: loganasherjones <loganasherjones@gmail.com>
Signed-off-by: loganasherjones <loganasherjones@gmail.com>
@loganasherjones loganasherjones force-pushed the add-resource-configuration-file-flag branch from ff62725 to 3dbd9fb Compare February 19, 2024 18:34
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Owner

@sgammon sgammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. This property is implemented on some other branches; there are more missing flags than just this one, as relates to configuration files that can be passed to native-image. We can merge this and rebase from there, though.

@loganasherjones
Copy link
Contributor Author

Awesome thanks! Yeah I saw you were tracking many of the missing configuration files, but had to create a fork anyway, so figured I'd contribute back! Thanks again.

@sgammon
Copy link
Owner

sgammon commented Feb 19, 2024

@loganasherjones Thanks for this contribution! It will make it into the next release. Unless you let me know differently, I'll mention you and this change in the release notes. 👍🏻

@sgammon sgammon merged commit e201dc6 into sgammon:main Feb 19, 2024
69 checks passed
@sgammon sgammon mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants