Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow setup: lint + test #152

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

ravwojdyla
Copy link
Contributor

@ravwojdyla ravwojdyla commented Apr 29, 2024

This PR depends on #151, which should be reviewed and merged first. This PR adda a CI workflow which runs both lint and tests.

Summary:

  • update relevant actions to avoid GH warnings
  • run both lint and test at the same time
  • tests run on python 3.9, 3.10 and 3.11
  • adds badge to the readme

@ravwojdyla ravwojdyla force-pushed the rav-ci-setup branch 2 times, most recently from 18b5b69 to cef57d1 Compare April 29, 2024 11:01
@ravwojdyla
Copy link
Contributor Author

ravwojdyla commented Apr 29, 2024

There appears to be some failures in tests/test_plink.py, they do not look related to this PR:

FAILED tests/test_plink.py::TestEqualSgkit::test_simulated_example - AttributeError: 'int' object has no attribute 'item'
FAILED tests/test_plink.py::TestExample::test_sgkit - AttributeError: 'int' object has no attribute 'item'

Those tests fail consistently across python versions ^, I suppose they could be fixed in a separate PR?

Copy link
Contributor

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yep, let's go ahead and merge this while failing, and can fix with a follow-up

@ravwojdyla
Copy link
Contributor Author

@jeromekelleher this should be good to go 🙏

@jeromekelleher jeromekelleher merged commit df7bab9 into sgkit-dev:main Apr 29, 2024
4 of 7 checks passed
@ravwojdyla ravwojdyla deleted the rav-ci-setup branch April 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants