Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct weight loading #3764

Closed
wants to merge 232 commits into from

Conversation

fzyzcjy
Copy link
Collaborator

@fzyzcjy fzyzcjy commented Feb 21, 2025

Motivation

Just #2845

This PR supports verl megatron weights to be passed in.

Modifications

Checklist

@FrankLeeeee
Copy link
Collaborator

Can you explain your PR a bit including the motivation and implementation?

@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Feb 22, 2025

@FrankLeeeee Hi, this is one PR among the series to integrate SGLang into Verl, and is being reviewed now. After the dependent PRs are merged, the code diff shown in github will be much cleaner.

@FrankLeeeee
Copy link
Collaborator

@FrankLeeeee Hi, this is one PR among the series to integrate SGLang into Verl, and is being reviewed now. After the dependent PRs are merged, the code diff shown in github will be much cleaner.

Noted, thanks!

@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Feb 22, 2025

You are welcome!

@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Feb 26, 2025

After discussing with Lianmin, now I know there is no need to follow implementation requirements in e.g. 2736. Thus I spent several hours writing a new PR #3852, and this one is deprecated.

@fzyzcjy fzyzcjy closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants