Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests about SPMD #3767

Closed
wants to merge 261 commits into from
Closed

Conversation

fzyzcjy
Copy link
Collaborator

@fzyzcjy fzyzcjy commented Feb 21, 2025

Motivation

The tests can be run locally by executing test_fragment.py. (It is skipped in CI, which mimics the test_generation_models.py).

Modifications

Checklist

@fzyzcjy fzyzcjy marked this pull request as ready for review February 21, 2025 14:29
fzyzcjy and others added 20 commits February 21, 2025 22:29
…ager

# Conflicts:
#	python/sglang/srt/openai_api/adapter.py
# Conflicts:
#	python/sglang/srt/managers/detokenizer_manager.py
# Conflicts:
#	python/sglang/srt/models/llama.py
@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Feb 26, 2025

After discussing with Lianmin, now I know there is no need to follow implementation requirements in e.g. 2736. Thus I spent several hours writing a new PR #3852, and this one is deprecated.

@fzyzcjy fzyzcjy closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant