Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve docs #3860

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

simveit
Copy link
Contributor

@simveit simveit commented Feb 25, 2025

Motivation

With this PR we implement the remaining points of this issue.

@zhaochenyang20 @shuaills please take a look at this.

@simveit
Copy link
Contributor Author

simveit commented Feb 26, 2025

Hi @zhaochenyang20 ,
I made the changes from above and included also the two small other issues here.

@zhaochenyang20 zhaochenyang20 marked this pull request as ready for review February 26, 2025 18:27
@zhaochenyang20 zhaochenyang20 merged commit 44a2c4b into sgl-project:main Feb 26, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants