Skip to content

Comments

llm: add model temperature mapping and temperature logging#6

Merged
sgoedecke merged 1 commit intosgoedecke:mainfrom
dwojtaszek:feat/model-temperature-mapping-log
Sep 21, 2025
Merged

llm: add model temperature mapping and temperature logging#6
sgoedecke merged 1 commit intosgoedecke:mainfrom
dwojtaszek:feat/model-temperature-mapping-log

Conversation

@dwojtaszek
Copy link
Contributor

This PR introduces a simple model->temperature mapping and logs the effective temperature used when calling the GitHub Models API.

Changes:

  • Add modelTemperatureMap and getMappedTemperature to internal/llm/client.go.
  • Use mapping (when present) to determine the temperature; otherwise use promptConfig.ModelParameters.Temperature.
  • Rename local variable to effectiveTemperature for clarity.
  • Add a console log that prints selected model and effective temperature before the API call.

Verification:

  • go build ./... passes locally.
  • Ran the CLI and observed the new log line (e.g. 'Selected model=openai/gpt-5-mini, temperature=1.00').

Notes:

  • No behavior changes other than temperature selection precedence and added logging.
  • Follow-ups: add unit tests, prefix-based model matching, or a verbose flag for the log.,

@sgoedecke sgoedecke merged commit 14b5448 into sgoedecke:main Sep 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants