-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PanktiSelector with transcriber support (WebSpeechApi + MSFT) #415
Open
manshantsingh
wants to merge
10
commits into
shabados:main
Choose a base branch
from
manshantsingh:panktiSelector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manshantsingh
commented
Jun 18, 2023
private static readonly transcriberNameCookieKey = 'TRANSCRIBER_NAME' | ||
private static readonly msftApiKeyCookieKey = 'SPEECH_KEY' | ||
private static readonly msftApiregionCookieKey = 'SPEECH_REGION' | ||
private static readonly openaiApiSecretCookieKey = 'OPENAI_SECRET' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private static readonly openaiApiSecretCookieKey = 'OPENAI_SECRET'
This is unused. I was thinking of implementing online whisper provider as well, but then focused on other things. Forgot to remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select Pankti based on speech (alpha version)
Please review this PR, and I will make the edits suggested along with my other future changes
Also, I am new to react and so if something I did the 'wrong' way, please let me know.
Short Summary
Overview of code changes
Added a new API in backend to allow fetching auth token for MicrosoftCognitiveServicesSpeechTranscriberHow to use:
How to use: (Advanced, custom Transcriber)
cookieName,cookieValue
pair (default key,value for WebSpeechApi is prefilled, you just need to press enter)Known issues: