docs(dark-mode): #4927 Remove step & address hydration warning #5774
+2
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blkhurst is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
ThemeProvider can now be imported from next-themes directly as a child component.
blkhurst
force-pushed
the
4927/docs-redundant-step
branch
from
b58b14f
to
7913686
Compare
Jacksonmills
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove Custom ThemeProvider:
The
next-themeslibrary suppliesThemeProvideras a client component, making a custom wrapper unnecessary. This aligns the docs with thenext-themesrecommendations.Highlight Hydration Warning:
The issue states a hydration error occurs when following the steps. I attempted to replicate, and believe highlighting the importance of adding
suppressHydrationWarningto the<html>tag is the key to prevent this error, as stated here:Closes #4927