Dhcp support #20
Open
Dhcp support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leases sync will fail gracefully if it doesn't exist or is empty (ie if dhcp server is disabled)
shaderecker
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Hi @ohthehugemanatee, many thanks for contributing this PR! I really appreciate it.
It looks good overall, can you check my two comments/questions 🙂
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| - name: Schedule sync with cron | |||
| ansible.builtin.cron: | |||
| hour: "2,14" | |||
There was a problem hiding this comment.
Can you revert those values to the originals please since the shorter sync interval is only needed for dhcp.
Maybe you can provide some example values, that you consider good, in the readme.
There was a problem hiding this comment.
At least in my experience the dns performance was impaired pretty easily, so I would like to keep the sync jobs to a minimum by default.
| @@ -35,4 +43,29 @@ if [[ ! $(ip a | grep {{ sync_target }}) ]]; then | |||
| sudo cp --preserve=timestamps $sync_dir/05-pihole-custom-cname.conf $pihole_dir/dnsmasq.d | |||
| fi | |||
| fi | |||
|
|
|||
| RSYNC_WILDCARD=$(rsync -a --info=name -e "ssh $key $host_key_check" $target:$pihole_dir/dnsmasq.d/02-cluster.vert-wildcard.conf $sync_dir) | |||
There was a problem hiding this comment.
What is the reason to sync this file separately when you later on sync the whole dnsmasq.d directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19