userdel: --force: Allow the flag to be specified twice, for more granularity #1071
+18
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
ff
branch
2 times, most recently
from
5d8ddfa
to
11c0e8b
Compare
…ularity Previously, with a single --force, one could only chose between not forcing, and forcing (which could destroy one's system entirely). Now one can pass --force, with only a small danger, to skip some checks, and a double --force --force with the meaning of the previous --force, which will possibly destroy the entire system. Closes: <shadow-maint#1050> Reported-by: Matthew Horsfall <wolfsage@gmail.com> Cc: Lennart Poettering <lennart@poettering.net> Cc: Serge Hallyn <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
ff
branch
from
11c0e8b
to
cb58058
Compare
Comment on lines
+85
to
+91
| If specified once, | ||
| a user is removed | ||
| even if it's still logged in, | ||
| and its primary group is removed | ||
| even if it's the primary group of another user. | ||
| If specified twice, | ||
| it skips all safety checks. |
There was a problem hiding this comment.
Does this distinction make sense? Should the group thing go with -ff?
There was a problem hiding this comment.
I think it's ok, but I ask just in case.
|
@wolfsage, can you please check if this looks good to you? Also, would you please test it? |
|
I don't like this change and I think it'll be problematic to some users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, with a single --force, one could only chose between not forcing, and forcing (which could destroy one's system entirely).
Now one can pass --force, with only a small danger, to skip some checks, and a double --force --force with the meaning of the previous --force, which will possibly destroy the entire system.
Closes: #1050
Reported-by: @wolfsage
Cc: @poettering
Cc: @hallyn
I have NOT tested this. Please test.
Revisions:
v2
v2b