lib/run_part: Minor cleanups #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stoeckmann
commented
Sep 13, 2024
stoeckmann
commented
- Use correct data type
- Unify logging (at least the fprintf calls)
- Reduce visibility of locally used function
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
stoeckmann
force-pushed
the
run_part
branch
from
11b5abc
to
742b1b0
Compare
Use shadow_logfd for logging instead of fixed stderr to use shadow's own logging infrastructure. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
The run_part function is only used in run_part.c itself, so no need to expose it to other files. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
stoeckmann
force-pushed
the
run_part
branch
from
2ff1b6a
to
029ebe5
Compare
At least if they can be assigned directly to a function call. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Remove some of these whitespaces. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
alejandro-colomar
approved these changes
Sep 13, 2024
ikerexxe
reviewed
Sep 17, 2024
ikerexxe
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.