Bugfix: Missing equals sign in the useradd command.

[kugarocks]

When I run useradd -D -s /bin/bash, the content of /etc/default/useradd file is missing the equals sign.

GROUP1000
GROUPS
HOME/home
INACTIVE-1
EXPIRE
SKEL/etc/skel
USRSKEL/usr/etc/skel
CREATE_MAIL_SPOOLyes
LOG_INITyes

I think the reason is that the definition of the constant changed on July 9, 2024.

d91b22cc2f6d99a7607e7844f91703651578394d

#define DGROUP		"GROUP="
#define DGROUPS		"GROUPS="
#define DHOME		"HOME="

a7b169be18625ddb6a46a78aad8a2421e3b051f9

#define DGROUP		"GROUP"
#define DGROUPS		"GROUPS"
#define DHOME		"HOME"

But the code below has not been updated accordingly.

skip:
/*
 * Check each line to insure that every line was output. This
 * causes new values to be added to a file which did not previously
 * have an entry for that value.
 */
if (!out_group)
	fprintf (ofp, DGROUP "%u\n", (unsigned int) def_group);
if (!out_groups)
	fprintf (ofp, DGROUPS "%s\n", def_groups);
if (!out_home)
	fprintf (ofp, DHOME "%s\n", def_home);

The code has been tested on Ubuntu 22.04 (Kernel 6.10.11). Please review my code when you are free. Thank you.
@alejandro-colomar

[alejandro-colomar]

Thank you very much! That was my mistake.
Please add:

Fixes: a7b169be1862 ("src/useradd.c: Use stpsep() to simplify")
Reviewed-by: Alejandro Colomar <alx@kernel.org>

To the commit message.

[kugarocks]

Thank you very much! That was my mistake. Please add:

Fixes: a7b169be1862 ("src/useradd.c: Use stpsep() to simplify")
Reviewed-by: Alejandro Colomar <alx@kernel.org>

To the commit message.

I have added the commit message, thanks.

[alejandro-colomar]

Please add src/useradd.c: to the commit message, to clarify to which program it applies.

I'll let @hallyn merge this.

[kugarocks]

Please add src/useradd.c: to the commit message, to clarify to which program it applies.

I'll let @hallyn merge this.

Done.

[hallyn]

Thanks