Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useradd: fix comparison sign for write_full() return #1087

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

ikerexxe
Copy link
Collaborator

@ikerexxe ikerexxe commented Oct 4, 2024

I forgot to change the comparison sign that checks the return value of write_full()

Closes: #1072
Fixes: 8903b94 ("useradd: fix write_full() return value")
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2313559

I forgot to change the comparison sign that checks the return value of
write_full()

Closes: shadow-maint#1072
Fixes: 8903b94 ("useradd: fix write_full() return value")
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2313559

Reported-by: <https://github.com/brown-midas>
Suggested-by: <https://github.com/brown-midas>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
@hallyn
Copy link
Member

hallyn commented Oct 5, 2024

I'm confused about the provenance, if you put a Reviewed-by in here... :)

But, merging - thank you.

@hallyn hallyn merged commit 9035932 into shadow-maint:master Oct 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useradd reports spurious warning "failed to reset the lastlog entry"
2 participants