Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasIntersection methods added. #2

Merged
merged 9 commits into from
May 7, 2024
Merged

HasIntersection methods added. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8388608
HasIntersection overloads added.
Mar 14, 2024
c520da1
HasIntersection unit tests added.
shadzhiyski May 3, 2024
366f38a
HasIntersection extension methods on Interval added.
shadzhiyski May 3, 2024
a8481b7
HasIntersection unit tests added.
shadzhiyski May 6, 2024
60a335b
Default IntervalType changed to Closed.
May 7, 2024
f40a4bc
Revert "Default IntervalType changed to Closed."
May 7, 2024
a83c7d5
Revert "Revert "Default IntervalType changed to Closed.""
May 7, 2024
b3f3b6f
Unit tests updated.
May 7, 2024
ad5ee05
StartClosed and EndClosed renamed to ENdOpen and StartOpen.
May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions EasyIntervals.Tests/IntervalComparerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,21 @@ namespace EasyIntervals.Tests;
public class IntervalComparerTests
{
[Fact]
public void SameStartFirstOpenSecondStartClosed_ShouldReturnOne()
public void SameStartFirstOpenSecondEndOpen_ShouldReturnOne()
{
var intervalComparer = IntervalComparer<int, int?>.Create(Comparer<int>.Default);

var result = intervalComparer.Compare((5, 12), (5, 10, IntervalType.StartClosed));
var result = intervalComparer.Compare((5, 12), (5, 10, IntervalType.EndOpen));

result.Should().Be(1);
}

[Fact]
public void SameStartFirstStartClosedSecondOpen_ShouldReturnMinusOne()
public void SameStartFirstEndOpenSecondOpen_ShouldReturnMinusOne()
{
var intervalComparer = IntervalComparer<int, int?>.Create(Comparer<int>.Default);

var result = intervalComparer.Compare((5, 12, IntervalType.StartClosed), (5, 10));
var result = intervalComparer.Compare((5, 12, IntervalType.EndOpen), (5, 10, IntervalType.Open));

result.Should().Be(-1);
}
Expand All @@ -27,7 +27,7 @@ public void SameStartSameStartTypeFirstGreaterEnd_ShouldReturnOne()
{
var intervalComparer = IntervalComparer<int, int?>.Create(Comparer<int>.Default);

var result = intervalComparer.Compare((5, 12, IntervalType.StartClosed), (5, 10, IntervalType.StartClosed));
var result = intervalComparer.Compare((5, 12, IntervalType.EndOpen), (5, 10, IntervalType.EndOpen));

result.Should().Be(1);
}
Expand All @@ -37,27 +37,27 @@ public void SameStartSameStartTypeFirstLowerEnd_ShouldReturnMinusOne()
{
var intervalComparer = IntervalComparer<int, int?>.Create(Comparer<int>.Default);

var result = intervalComparer.Compare((5, 9, IntervalType.StartClosed), (5, 10, IntervalType.StartClosed));
var result = intervalComparer.Compare((5, 9, IntervalType.EndOpen), (5, 10, IntervalType.EndOpen));

result.Should().Be(-1);
}

[Fact]
public void SameLimitsSameStartTypeFirstEndClosed_ShouldReturnOne()
public void SameLimitsSameStartTypeFirstStartOpen_ShouldReturnOne()
{
var intervalComparer = IntervalComparer<int, int?>.Create(Comparer<int>.Default);

var result = intervalComparer.Compare((5, 10, IntervalType.Closed), (5, 10, IntervalType.StartClosed));
var result = intervalComparer.Compare((5, 10, IntervalType.Closed), (5, 10, IntervalType.EndOpen));

result.Should().Be(1);
}

[Fact]
public void SameLimitsSameStartTypeSecondEndClosed_ShouldReturnMinusOne()
public void SameLimitsSameStartTypeSecondStartOpen_ShouldReturnMinusOne()
{
var intervalComparer = IntervalComparer<int, int?>.Create(Comparer<int>.Default);

var result = intervalComparer.Compare((5, 10, IntervalType.StartClosed), (5, 10, IntervalType.Closed));
var result = intervalComparer.Compare((5, 10, IntervalType.EndOpen), (5, 10, IntervalType.Closed));

result.Should().Be(-1);
}
Expand All @@ -67,7 +67,7 @@ public void SameLimitsSameTypes_ShouldReturnZero()
{
var intervalComparer = IntervalComparer<int, int?>.Create(Comparer<int>.Default);

var result = intervalComparer.Compare((5, 10, IntervalType.StartClosed), (5, 10, IntervalType.StartClosed));
var result = intervalComparer.Compare((5, 10, IntervalType.EndOpen), (5, 10, IntervalType.EndOpen));

result.Should().Be(0);
}
Expand Down
50 changes: 50 additions & 0 deletions EasyIntervals.Tests/IntervalExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
namespace EasyIntervals.Tests;

public class IntervalExtensionsTests
{
[Fact]
public void HasIntersection_IntersectingIntervals_ShouldReturnTrue()
{
Interval<int, int?> interval = (2, 5);
Interval<int, int?> other = (4, 8);

var result = interval.HasIntersection(other, IntersectionType.Any);

result.Should().BeTrue();
}

[Fact]
public void HasIntersection_NotIntersectingIntervals_ShouldReturnFalse()
{
Interval<int, int?> interval = (2, 5);
Interval<int, int?> other = (6, 8);

var result = interval.HasIntersection(other, IntersectionType.Any);

result.Should().BeFalse();
}

[Fact]
public void HasIntersection_IntersectingIntervalsWithCustomComparer_ShouldReturnTrue()
{
var comparer = Comparer<int>.Create((i1, i2) => i2 - i1);
Interval<int, int?> interval = (5, 2, comparer);
Interval<int, int?> other = (8, 4, comparer);

var result = interval.HasIntersection(other, IntersectionType.Any, comparer);

result.Should().BeTrue();
}

[Fact]
public void HasIntersection_NotIntersectingIntervalsWithCustomComparer_ShouldReturnFalse()
{
var comparer = Comparer<int>.Create((i1, i2) => i2 - i1);
Interval<int, int?> interval = (5, 2, comparer);
Interval<int, int?> other = (8, 6, comparer);

var result = interval.HasIntersection(other, IntersectionType.Any, comparer);

result.Should().BeFalse();
}
}
Loading
Loading