Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#issue 25 Resolved Page breaking down at bottom #40

Closed
wants to merge 3 commits into from
Closed

#issue 25 Resolved Page breaking down at bottom #40

wants to merge 3 commits into from

Conversation

pranjalagrawal2012
Copy link

@pranjalagrawal2012 pranjalagrawal2012 commented Mar 14, 2021 •
edited
Loading

Related Issue

Back Arrow in each page was not working properly

Breaking body page on bottom

Closes: #[issue number that will be closed through this PR]

issue-23

issue-25

Describe the changes you've made

Went through various upgradation of packages and flutter updating, Check every page for the back arrow issue

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

Additional Info (optional)

Any additional information you want to give

@hiashutoshsingh
Copy link
Collaborator

WhatsApp Image 2021-03-16 at 10 48 59 AM (1)
WhatsApp Image 2021-03-16 at 10 48 59 AM
WhatsApp Image 2021-03-16 at 10 49 00 AM

@pranjalagrawal2012 UI is breaking on some phone. I tested this on a 5.5-inch android phone.
What you can do here to make it responsive on all phones. This is a very easy-peasy task.

Let me know if you need some help with this.

@hiashutoshsingh
Copy link
Collaborator

It's not recommended to send a lock file(e.g pubspec.lock) from another environment. It should remain intact with one user only. @pranjalagrawal2012

hiashutoshsingh
hiashutoshsingh requested changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@hiashutoshsingh hiashutoshsingh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change the pull request name to something meaningful.
  2. Fix the UI changes

@pranjalagrawal2012

@hiashutoshsingh hiashutoshsingh linked an issue Mar 17, 2021 that may be closed by this pull request
Page breaking down at bottom #25
Open
@pranjalagrawal2012
Copy link
Author

Made the Changes and resolved the issue of screen overflowing @hiashutoshsingh @shagun25

@pranjalagrawal2012 pranjalagrawal2012 changed the title Issue-23 & Issue-25 Resolved Page breaking down at bottom #issue 25 Mar 17, 2021
@pranjalagrawal2012 pranjalagrawal2012 changed the title Page breaking down at bottom #issue 25 Page breaking down at bottom #issue 25 and Back button not working on all places #issue 23 Mar 17, 2021
@pranjalagrawal2012 pranjalagrawal2012 changed the title Page breaking down at bottom #issue 25 and Back button not working on all places #issue 23 #issue 25 Resolved Page breaking down at bottom Mar 17, 2021
@hiashutoshsingh
Copy link
Collaborator

@pranjalagrawal2012 Hey, you look into these conflicts. I hope you are behind master. Please do this carefully this may break something.

hiashutoshsingh
hiashutoshsingh requested changes Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@hiashutoshsingh hiashutoshsingh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve these changes.
@pranjalagrawal2012

Sheheroes_WatchOS/pubspec.lock Outdated
@@ -63,7 +63,7 @@ packages:
name: async
url: "https://pub.dartlang.org"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file from commit, lock file is not added usually.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay @hiashutoshsingh

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the padding field whose value is assigned to 0 . Can you guide me how to remove the file from commit ??

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiashutoshsingh Can you please review the same ?

lib/pages/login_page.dart Outdated
@@ -445,7 +447,7 @@ class _LoginPageState extends State<LoginPage>

Widget _buildSignUp(BuildContext context) {
return Container(
padding: EdgeInsets.only(top: 23.0),
padding: EdgeInsets.only(top: 0.0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no padding is need then remove this padding field rather that assigning its value to 0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay @hiashutoshsingh

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiashutoshsingh have removed the padding field whose value is assigned to 0

pubspec.lock
@@ -63,7 +63,7 @@ packages:
name: async
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file also from commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay @hiashutoshsingh

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiashutoshsingh Can you guide me how to remove the file from commit ??

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a copy of the file at another place and delete that file then commit it.

@hiashutoshsingh
Copy link
Collaborator

Hey, @pranjalagrawal2012 didn't get an update from your side.
Is there any issue are facing to making changes. Let me know.

@hiashutoshsingh hiashutoshsingh self-requested a review March 21, 2021 05:33
@hiashutoshsingh hiashutoshsingh added gssoc21 Level2 Bug fixing, adding small features. labels Mar 21, 2021
@hiashutoshsingh
Copy link
Collaborator

Hey, closing this PR because it is awaiting for a long time. Feel free to open again with new changes.

Thanks.

@pranjalagrawal2012 pranjalagrawal2012 mentioned this pull request Apr 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shagun25 shagun25 Awaiting requested review from shagun25

@hiashutoshsingh hiashutoshsingh Awaiting requested review from hiashutoshsingh

Assignees

@pranjalagrawal2012 pranjalagrawal2012

Labels
gssoc21 Level2 Bug fixing, adding small features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page breaking down at bottom
2 participants
@pranjalagrawal2012 @hiashutoshsingh