-
Notifications
You must be signed in to change notification settings - Fork 4
Add node_no_warnings environment variable #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAn environment variable assignment Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/cpflow.rb (1)
54-54: Inactive ENV assignment – confirm intention
The line settingENV["NODE_NO_WARNINGS"] = "1"is currently commented out, so it has no effect at runtime. Since this PR’s purpose is to suppress Node warnings viaNODE_NO_WARNINGS, please verify whether you intended to enable this assignment:- # ENV["NODE_NO_WARNINGS"] = "1" + ENV["NODE_NO_WARNINGS"] = "1"If it’s no longer needed (e.g., the underlying debug issue is already resolved), consider removing this dead code.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/cpflow.rb(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: RSpec (Fast) / rspec
While figuring out how to test this locally, I also encountered a really old error with the debug gem that should have been resolved a long time ago (I'm using Ruby 2.7.3).
Summary by CodeRabbit