fix: don't recommend deprecated https config option (#380)

shakacode · Nov 23, 2023 · a954000 · a954000
1 parent 556f92c
commit a954000
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,9 @@ _Please add entries here for your pull requests that are not yet released._
 ### Added
 - Experimental support for other JS package managers using `package_json` gem [PR 349](https://github.com/shakacode/shakapacker/pull/349) by [G-Rath](https://github.com/g-rath).
 
+### Fixed
+- Recommend `server` option instead of deprecated `https` option when `--https` is provided [PR 380](https://github.com/shakacode/shakapacker/pull/380) by [G-Rath](https://github.com/g-rath)
+
 ## [v7.1.0] - September 30, 2023
 
 ### Added

diff --git a/lib/shakapacker/dev_server_runner.rb b/lib/shakapacker/dev_server_runner.rb
@@ -48,7 +48,7 @@ def detect_unsupported_switches!
         end
 
         if @argv.include?("--https") && !@https
-          $stdout.puts "Please set https: true in shakapacker.yml to use the --https command line flag."
+          $stdout.puts "--https requires that 'server' in shakapacker.yml is set to 'https'"
           exit!
         end
       end
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,7 +48,7 @@ def detect_unsupported_switches! @@
             end
             if @argv.include?("--https") && !@https
-              $stdout.puts "Please set https: true in shakapacker.yml to use the --https command line flag."
+              $stdout.puts "--https requires that 'server' in shakapacker.yml is set to 'https'"
               exit!
             end
           end
@@ Expand Down @@