-
-
Notifications
You must be signed in to change notification settings - Fork 97
Limit workflow jobs #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit workflow jobs #544
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -18,10 +18,8 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest] | |||
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, if I may suggest, please test at least once on the least supported version, because this can lead to unintended breaking changes at patch level.
Example: using intersect?
which is a 3.1 feature. In the past this was a plague with the safe navigation operator
This happened in several repos in the past. I strongly suggest to use something like
include:
gemfile: oldest_gemfile
ruby: old_supported_ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just me trying various things to see if the npm failsures go away, but they seem to be endemic. Won't be merging this
Summary
Pull Request checklist
Other Information