Open
Conversation
WoWaster
requested changes
Dec 16, 2025
Collaborator
WoWaster
left a comment
WoWaster
left a comment
There was a problem hiding this comment.
Честно говоря, выглядит так, будто Вы это в попыхах то ли списали, то ли нагенерили.
| double getMantissa(Number num); | ||
|
|
||
|
|
||
| int getBit(Number num, int i); |
Collaborator
There was a problem hiding this comment.
Правда ли эта функция нужна извне?
Comment on lines
+31
to
+36
| TestNumber(-2.0, "-1*2^1"); | ||
| TestNumber(2.0, "+1*2^1"); | ||
| TestNumber(1.0, "+1*2^0"); | ||
| TestNumber(-1.0, "-1*2^0"); | ||
| TestNumber(0.5, "+1*2^-1"); | ||
| TestNumber(-0.5, "-1*2^-1"); |
Collaborator
There was a problem hiding this comment.
А чуть более сложные тесты? Например на непредставимых точно числах?
Comment on lines
+7
to
+11
| bool DoubleEquals(double a, double b, double eps) { | ||
| return fabs(a - b) < eps; | ||
| } | ||
|
|
||
| bool TestNumber(double value, const char* expected) { |
Collaborator
There was a problem hiding this comment.
А что тут со стилем кода стало???
Comment on lines
+9
to
+11
| int getSign(Number num); | ||
| int getExponent(Number num); | ||
| double getMantissa(Number num); |
| #include "DoubleMicroscope.h" | ||
|
|
||
|
|
||
| int getBit(Number num, int i) { |
Collaborator
There was a problem hiding this comment.
Код надо отформатировать.
| #include "DoubleMicroscope.h" | ||
|
|
||
| int main() { | ||
| Number num; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Шалахина Анна дз-12