Add cz-github-issues as an issue source for cz-component-dash in animations-ave.json #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
alancutter
commented
Oct 19, 2016
| var issueSource = issueSources[this.key]; | ||
| registerSource(issueSource.tag, issueSource.query, issueList => { | ||
| this.set('issueList', issueList); | ||
| }); |
There was a problem hiding this comment.
Oops, thought I reverted the updateIssueSource() split in the previous patch.
alancutter
commented
Oct 19, 2016
| @@ -100,7 +100,7 @@ | |||
| is: "cz-component-dash", | |||
|
|
|||
| properties: { | |||
| users: { | |||
| userConfigs: { | |||
There was a problem hiding this comment.
I can anticipate disapproval for this rename, it has a weaker line of reasoning than searchQuery.query.
shans
approved these changes
Oct 19, 2016
| registerSource('cz-config', 'users', users => { | ||
| this.set('users', users.map(userData => userData['email'])); | ||
| registerSource('cz-config', 'users', userConfigs => { | ||
| this.set('userConfigs', userConfigs); |
| var issueSource = issueSources[this.key]; | ||
| registerSource(issueSource.tag, issueSource.query, issueList => { | ||
| this.set('issueList', issueList); | ||
| }); |
| var team = new IssueList(); | ||
| var others = new IssueList(); | ||
| var unowned = new IssueList(); | ||
| if (issueList) { | ||
| for (var issue of issueList) { | ||
| if (issue.owner == null) { | ||
| unowned.push(issue); | ||
| } else if (this.users.indexOf(issue.owner) === -1) { | ||
| } else if (!usernames.has(issue.owner)) { |
There was a problem hiding this comment.
FYI, you can use .includes on a list directly now, so you don't need to Set-ify usernames (I don't think there's any other reason to do that here as it isn't edited anywhere).
| return; | ||
| } | ||
| var usernames = userConfigs.map(userConfig => issueList.getUsername(userConfig)); | ||
| this.set('usernames', new Set(usernames)); |
|
Changed usernames to an array, replaced some this.set() calls to assignment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new component dash to animations-ave.json showing web-animations-js polyfill issue statuses.
Preview:
This change builds upon #76.
BUG=#72
+@suzyh as author of cz-component-dash.