Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3.9 and 3.8 error #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josesaranda
Copy link

This MR fixes khiva-python dll location for python 3.9 version

@josesaranda josesaranda self-assigned this Jul 27, 2021
Copy link
Contributor

@avilchess avilchess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesaranda josesaranda removed the request for review from daniram9 July 27, 2021 12:43
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #62 (2ed40b0) into master (891622c) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   84.84%   84.65%   -0.19%     
==========================================
  Files          14       14              
  Lines        1597     1597              
==========================================
- Hits         1355     1352       -3     
- Misses        242      245       +3     
Flag Coverage Δ
Linux ?
MacOS ?
Windows 84.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
khiva/library.py 84.37% <100.00%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891622c...2ed40b0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants