Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase lit test coverage #1158

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Increase lit test coverage #1158

merged 9 commits into from
Feb 6, 2025

Conversation

caseyhans
Copy link
Collaborator

@caseyhans caseyhans commented Jan 17, 2025 •
edited
Loading

  • Increase test coverage for the lit module:
    • Test reference filterset
    • Test Workflows
  • Fix labeled items search bug
  • Fix invalid literature workflow in the fixture
  • Add test for serializer FilterReferences

@caseyhans caseyhans requested a review from rabstejnek January 22, 2025 05:36
@caseyhans caseyhans marked this pull request as ready for review January 22, 2025 05:36
rabstejnek
rabstejnek approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@rabstejnek rabstejnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

shapiromatron
shapiromatron approved these changes Feb 6, 2025
View reviewed changes
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a test for the PydanticDrfSerializer to better understand the changes you made to that class, I guess we should have had tests there in the first place.

@shapiromatron shapiromatron merged commit 71d4e4c into main Feb 6, 2025
6 checks passed
@shapiromatron shapiromatron deleted the increase-lit-coverage branch February 6, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shapiromatron shapiromatron shapiromatron approved these changes

@rabstejnek rabstejnek rabstejnek approved these changes

Assignees

@shapiromatron shapiromatron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caseyhans @shapiromatron @rabstejnek