Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite visual forms using react instead of jQuery #1162

Open
wants to merge 33 commits into
base: dp-to-visual
Choose a base branch
from

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Jan 28, 2025

This PR should be reviewed after #1114

There were a few legacy jQuery applications for building custom visuals in HAWC. These user-interfaces did not perform well and had some bugs, but because they were so complicated, we never were able to fix them and they remained in this painful state. Because of the inability to change the applications, we had a really complicated django view and form layout too, since we had multiple different approaches depending on the frontend technology being used. This PR removes the jQuery applications and fully switch to a react frontend. This should dramatically improve stability of the application.

This rewrites the form frontend for Crossview, RobHeatmap, and RobBarchart.

In addition:

  • Refactor and standardize visual form startup javascript
  • Rewrite how the django-form panel is being used in React. Instead of recreating the django form with React, we have move the form in the react tab, and then out of the react tab, so that we're not duplicating state.
  • Rewrite the dose units selector widget to use React instead of the jQuery custom solution. See PreferredWidget.
  • Added tests to improve test coverage for the diversity of visual types and evidence types
  • Remove VisualizationCreateTester
  • Refactor how data for preview of visualizations is generated and passed to the application.

@shapiromatron shapiromatron changed the base branch from main to dp-to-visual January 28, 2025 04:18
@shapiromatron shapiromatron marked this pull request as ready for review February 6, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants